fix: address gemini-code-assist 4th review on PR #1

Accepted (5 / 9):

- .pre-commit-config.yaml: bump astral-sh/ruff-pre-commit rev v0.8.4
  → v0.15.13. The 0.8.4 tag really does not exist (gemini was right);
  v0.15.13 is current and matches the pinned `ruff` runtime version.
  [HIGH]
- .github/dependabot.yml: Asia/Tokyo → Etc/UTC for all three update
  blocks. Neutral default for a public repo. [MEDIUM]
- README.md: rewrite the scoring formula description to match the
  actual `(freshness × 2) + (keyword × source-weight) + severity`
  implementation (it was incorrectly listed as fully multiplicative).
  Also update the Layout block: `pr-checks.yml` was replaced by
  `ci.yml` plus `codeql.yml` and `audit.yml` two commits ago but the
  doc still pointed at the old name. [MEDIUM]
- scripts/awsdd/_dates.py (new): house the shared `parse_iso` and an
  EPOCH constant. score.py and report.py now import from it instead
  of carrying duplicate `_parse_iso` definitions. [MEDIUM - DRY]
- web/src/lib/data.ts: hoist the `86_400_000` magic number into a
  `MS_IN_DAY` constant. [MEDIUM]

Rejected (4 / 9), reasoning:

- requirements{,-dev}.txt "version does not exist" [CRITICAL ×2]:
  verified via `curl https://pypi.org/pypi/<pkg>/<ver>/json` — all
  seven pinned versions return HTTP 200 and `pip install` succeeds
  both locally and in every prior CI run. Gemini's knowledge cutoff
  predates these releases; the pins stay.
- pyproject.toml `SIM108` (ternary nag) [MEDIUM]: deliberately
  disabled because `if/else` blocks often read clearer than nested
  ternaries in this code base. No change.
- collect_rss `BeautifulSoup` swap [MEDIUM]: regex strip + DOMPurify
  sanitization on the rendering side already cover the layered
  defense; the dep cost outweighs the marginal robustness gain for
  the well-formed AWS feeds we consume. No change.

Regenerated seed reports so the committed sample matches the (byte-
identical) output the formatter now produces.

Author: kanywst

.github/dependabot.yml

@@ -7,7 +7,7 @@ updates:
       interval: weekly
       day: monday
       time: "09:00"
-      timezone: Asia/Tokyo
+      timezone: Etc/UTC
     open-pull-requests-limit: 5
     labels:
       - dependencies
@@ -21,7 +21,7 @@ updates:
       interval: weekly
       day: monday
       time: "09:00"
-      timezone: Asia/Tokyo
+      timezone: Etc/UTC
     open-pull-requests-limit: 5
     labels:
       - dependencies
@@ -50,7 +50,7 @@ updates:
       interval: weekly
       day: monday
       time: "09:00"
-      timezone: Asia/Tokyo
+      timezone: Etc/UTC
     open-pull-requests-limit: 5
     labels:
       - dependencies

.pre-commit-config.yaml

@@ -1,6 +1,6 @@
 repos:
   - repo: https://github.com/astral-sh/ruff-pre-commit
-    rev: v0.8.4
+    rev: v0.15.13
     hooks:
       - id: ruff
         args: [--fix]

README.md

@@ -21,7 +21,7 @@ Site: <https://0-draft.github.io/aws-deepdive/>
 collect (RSS + GitHub Releases) → normalize → score → report (daily | weekly)
 ```
 
-Score = `freshness × keyword × source-weight × severity`. Items below the threshold stay in `normalized.json` but are not surfaced in the report.
+Score = `(freshness × 2) + (keyword × source-weight) + severity`. The keyword × source-weight product means an item with zero keyword hits only gets the freshness baseline, so generic What's-New noise does not float into topic-specific tracks. See [`scripts/awsdd/score.py`](./scripts/awsdd/score.py) for the exact weights.
 
 ## Layout
 
@@ -38,10 +38,12 @@ tracks/<name>/
   reports/{daily,weekly}/<date>.md
   deep-dives/<topic>.md
 .github/workflows/
+  ci.yml                           # PR + push to main: lint / test / build
+  codeql.yml                       # CodeQL SAST (python + js/ts)
+  audit.yml                        # pip-audit + npm audit + license report
   daily-update.yml                 # 06:00 UTC, matrix.track
   weekly-digest.yml                # Mon 08:00 UTC
   deploy-pages.yml                 # push to main → Pages
-  pr-checks.yml
 web/                               # Astro 6 + Tailwind v4 + recharts (React island)
 ```
 
@@ -63,14 +65,14 @@ Python 3.12 / Node 22+ (Astro 6 requirement).
 
 ## CI
 
-| Workflow             | Trigger                                | Purpose                                                                  |
-| -------------------- | -------------------------------------- | ------------------------------------------------------------------------ |
-| `ci.yml`             | PR + push to `main` (code paths only)  | ruff, astro check, markdownlint, actionlint, pytest+coverage, builds     |
-| `codeql.yml`         | PR + push to `main` + weekly cron      | CodeQL SAST for Python and TS/JS                                         |
-| `audit.yml`          | weekly cron + manual + deps PR         | `pip-audit`, `npm audit --audit-level=high`, license report (copyleft gate) |
-| `daily-update.yml`   | 06:00 UTC cron                         | per-track collect / score / report; commits artefacts to `main`          |
-| `weekly-digest.yml`  | Mon 08:00 UTC cron                     | per-track weekly digest; commits artefact to `main`                      |
-| `deploy-pages.yml`   | push to `main` (web/, tracks/ changes) | builds `web/dist` and publishes to GitHub Pages                          |
+| Workflow            | Trigger                                | Purpose                                                                     |
+| ------------------- | -------------------------------------- | --------------------------------------------------------------------------- |
+| `ci.yml`            | PR + push to `main` (code paths only)  | ruff, astro check, markdownlint, actionlint, pytest+coverage, builds        |
+| `codeql.yml`        | PR + push to `main` + weekly cron      | CodeQL SAST for Python and TS/JS                                            |
+| `audit.yml`         | weekly cron + manual + deps PR         | `pip-audit`, `npm audit --audit-level=high`, license report (copyleft gate) |
+| `daily-update.yml`  | 06:00 UTC cron                         | per-track collect / score / report; commits artefacts to `main`             |
+| `weekly-digest.yml` | Mon 08:00 UTC cron                     | per-track weekly digest; commits artefact to `main`                         |
+| `deploy-pages.yml`  | push to `main` (web/, tracks/ changes) | builds `web/dist` and publishes to GitHub Pages                             |
 
 PRs into `main` should be gated by branch protection requiring `ci.yml` jobs to pass. Configure once in repo Settings → Branches.
 

scripts/awsdd/_dates.py

@@ -0,0 +1,18 @@
+from __future__ import annotations
+
+from datetime import UTC, datetime
+
+EPOCH = datetime(1970, 1, 1, tzinfo=UTC)
+
+
+def parse_iso(s: str) -> datetime:
+    """Parse an ISO-8601 string into a UTC-aware datetime.
+
+    Falls back to the Unix epoch (not "now") so corrupted or missing
+    timestamps sink to the bottom of freshness rankings instead of being
+    promoted to the top.
+    """
+    try:
+        return datetime.fromisoformat(s or "")
+    except (ValueError, TypeError):
+        return EPOCH

scripts/awsdd/report.py

@@ -4,22 +4,13 @@
 import json
 from datetime import UTC, datetime, timedelta
 
+from ._dates import parse_iso
 from .config import track_dir
 
 TOP_N = {"daily": 10, "weekly": 25}
 WINDOW = {"daily": timedelta(days=2), "weekly": timedelta(days=7)}
 
 
-def _parse_iso(s: str) -> datetime:
-    # Python 3.11+ accepts the "Z" suffix natively.
-    # Fall back to the Unix epoch (not "now") so corrupted dates sink below
-    # the freshness window instead of getting promoted to the top.
-    try:
-        return datetime.fromisoformat(s or "")
-    except (ValueError, TypeError):
-        return datetime(1970, 1, 1, tzinfo=UTC)
-
-
 def _filename(mode: str, now: datetime) -> str:
     if mode == "daily":
         return f"{now:%Y-%m-%d}.md"
@@ -32,7 +23,7 @@ def render(track: str, mode: str) -> None:
     items: list[dict] = json.loads(p.read_text()) if p.exists() else []
     now = datetime.now(UTC)
     cutoff = now - WINDOW[mode]
-    fresh = [it for it in items if _parse_iso(it.get("published_at", "")) >= cutoff]
+    fresh = [it for it in items if parse_iso(it.get("published_at", "")) >= cutoff]
     fresh.sort(key=lambda x: x.get("score", 0.0), reverse=True)
 
     used_fallback = False

scripts/awsdd/score.py

@@ -5,23 +5,14 @@
 import math
 from datetime import UTC, datetime
 
+from ._dates import parse_iso
 from .config import load_sources, track_dir
 
 SEVERITY_WEIGHT = {"critical": 3.0, "high": 2.0, "medium": 1.0, "low": 0.5}
 
 
-def _parse_iso(s: str) -> datetime:
-    # Python 3.11+ accepts the "Z" suffix natively.
-    # Fall back to the Unix epoch (not "now") so corrupted dates yield ~0
-    # freshness instead of an artificial max.
-    try:
-        return datetime.fromisoformat(s or "")
-    except (ValueError, TypeError):
-        return datetime(1970, 1, 1, tzinfo=UTC)
-
-
 def score_item(item: dict, sources: dict, now: datetime) -> dict[str, float]:
-    pub = _parse_iso(item.get("published_at", ""))
+    pub = parse_iso(item.get("published_at", ""))
     days = max(0.0, (now - pub).total_seconds() / 86400.0)
     freshness = math.exp(-days / 14.0)  # ~14-day decay
 

web/src/lib/data.ts

@@ -67,13 +67,15 @@ export function loadReports(track: Track, mode: "daily" | "weekly"): Report[] {
     }));
 }
 
+const MS_IN_DAY = 86_400_000;
+
 function isoWeekKey(d: Date): string | null {
   if (Number.isNaN(d.valueOf())) return null;
   const tmp = new Date(Date.UTC(d.getUTCFullYear(), d.getUTCMonth(), d.getUTCDate()));
   const dayNum = tmp.getUTCDay() || 7;
   tmp.setUTCDate(tmp.getUTCDate() + 4 - dayNum);
   const yearStart = Date.UTC(tmp.getUTCFullYear(), 0, 1);
-  const week = Math.ceil(((tmp.valueOf() - yearStart) / 86_400_000 + 1) / 7);
+  const week = Math.ceil(((tmp.valueOf() - yearStart) / MS_IN_DAY + 1) / 7);
   return `${tmp.getUTCFullYear()}-W${String(week).padStart(2, "0")}`;
 }