Commit 4b7692d
committed
fix: address gemini-code-assist 3rd review on PR #1
Type precision:
- schema.Item.source_kind is now Literal["rss", "github"] instead of
bare str, matching the comment and actual usage.
Robustness:
- report.render now escapes both `[` and `]` in titles (previously only
`]`), so titles like "[CVE-2026-xxx]" cannot collide with markdown
link parsing.
- normalize.normalize: narrow the two bare `except Exception` blocks
to `(OSError, json.JSONDecodeError)` so genuine bugs surface instead
of being swallowed.
- collect_github._get: narrow the fallback `except Exception` to
`(URLError, TimeoutError, json.JSONDecodeError)` (HTTPError is still
caught separately above).
Reproducibility:
- requirements.txt and requirements-dev.txt now pin exact versions
with `==`. Dependabot continues to PR upgrades, but a fresh checkout
+ `pip install -r ...` now resolves to a known-good set.
Config / docs:
- tracks/iam/config/sources.yaml: drop `spiffe/spiffe` (verified via
GitHub API: repo exists but has zero releases — it's the specs
tree, not a release surface).
- README.md: remove the duplicate 3-bullet "CI" section that the new
CI table superseded.
Regenerated today's seed reports under tracks/*/reports/ so they
match the new formatter output (extra `\[` escape would only matter
on titles containing `[`, but regen keeps the committed sample byte-
identical to what CI would produce now).1 parent a14a5b7 commit 4b7692d
8 files changed
Lines changed: 19 additions & 21 deletions
File tree
- scripts/awsdd
- tracks/iam/config
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
45 | 45 | | |
46 | 46 | | |
47 | 47 | | |
48 | | - | |
49 | | - | |
50 | | - | |
51 | | - | |
52 | | - | |
53 | | - | |
54 | 48 | | |
55 | 49 | | |
56 | 50 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
3 | | - | |
4 | | - | |
5 | | - | |
| 1 | + | |
| 2 | + | |
| 3 | + | |
| 4 | + | |
| 5 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | | - | |
2 | | - | |
| 1 | + | |
| 2 | + | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
5 | 5 | | |
6 | 6 | | |
7 | 7 | | |
8 | | - | |
| 8 | + | |
9 | 9 | | |
10 | 10 | | |
11 | 11 | | |
| |||
38 | 38 | | |
39 | 39 | | |
40 | 40 | | |
41 | | - | |
| 41 | + | |
42 | 42 | | |
43 | 43 | | |
44 | 44 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
15 | 15 | | |
16 | 16 | | |
17 | 17 | | |
18 | | - | |
| 18 | + | |
19 | 19 | | |
20 | 20 | | |
21 | 21 | | |
| |||
29 | 29 | | |
30 | 30 | | |
31 | 31 | | |
32 | | - | |
| 32 | + | |
33 | 33 | | |
34 | 34 | | |
35 | 35 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
72 | 72 | | |
73 | 73 | | |
74 | 74 | | |
75 | | - | |
| 75 | + | |
| 76 | + | |
| 77 | + | |
76 | 78 | | |
77 | 79 | | |
78 | 80 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
1 | 1 | | |
2 | 2 | | |
3 | 3 | | |
4 | | - | |
| 4 | + | |
| 5 | + | |
| 6 | + | |
5 | 7 | | |
6 | 8 | | |
7 | 9 | | |
8 | 10 | | |
9 | 11 | | |
10 | 12 | | |
11 | 13 | | |
12 | | - | |
| 14 | + | |
13 | 15 | | |
14 | 16 | | |
15 | 17 | | |
| |||
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
47 | 47 | | |
48 | 48 | | |
49 | 49 | | |
50 | | - | |
| 50 | + | |
0 commit comments