Commit 76e0bf7
committed
docs(response): clarify v1 scope per Gemini Code Assist feedback
Three medium-priority concerns from the review needed reconciliation
between the design doc and the v1 implementation:
1. Replacement contract: doc claimed structured replacement (status /
body / headers from the rule's value). v1 actually returns bool
from the evaluator and does a fixed 503 on deny. The structured
replacement requires the evaluator to surface json.Value plus a
discriminator and is deferred to a follow-up PR. Doc now splits
'v1' (fixed 503) from 'deferred' (structured).
2. 503 vs 403 asymmetry: doc didn't say which deny code response-side
uses, request-side already returns 403. v1 uses 503 on the
response side (upstream being replaced) vs 403 on the request
side (request rejected before upstream). Doc now states this
explicitly as intentional.
3. Backward compat for nested input shape: doc showed
'{request, response}' nested input which would have broken
existing input.method / input.path refs. v1 keeps the request-side
input flat (unchanged) and adds 'input.response.*' ONLY for the
allow_response target rule. input.request.* is reserved for the
v2 post-snapshot picture. Doc now shows v1 vs v2 input shapes
separately and clarifies 'allow' policies are untouched.
Per-context state section also corrected: v1 does not snapshot
request fields. The snapshot lives behind body-aware-policies.md
(PR #6) and shows up here only when that lands.1 parent 44817df commit 76e0bf7
1 file changed
Lines changed: 48 additions & 15 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
27 | 27 | | |
28 | 28 | | |
29 | 29 | | |
30 | | - | |
| 30 | + | |
| 31 | + | |
| 32 | + | |
31 | 33 | | |
32 | 34 | | |
33 | 35 | | |
| |||
46 | 48 | | |
47 | 49 | | |
48 | 50 | | |
49 | | - | |
50 | | - | |
51 | | - | |
| 51 | + | |
| 52 | + | |
| 53 | + | |
52 | 54 | | |
53 | 55 | | |
54 | 56 | | |
| |||
58 | 60 | | |
59 | 61 | | |
60 | 62 | | |
| 63 | + | |
| 64 | + | |
| 65 | + | |
| 66 | + | |
| 67 | + | |
61 | 68 | | |
62 | 69 | | |
| 70 | + | |
| 71 | + | |
| 72 | + | |
| 73 | + | |
| 74 | + | |
63 | 75 | | |
| 76 | + | |
64 | 77 | | |
65 | | - | |
66 | | - | |
67 | | - | |
68 | | - | |
69 | | - | |
70 | 78 | | |
71 | 79 | | |
72 | 80 | | |
73 | 81 | | |
74 | 82 | | |
75 | 83 | | |
76 | 84 | | |
| 85 | + | |
| 86 | + | |
| 87 | + | |
| 88 | + | |
| 89 | + | |
| 90 | + | |
| 91 | + | |
| 92 | + | |
| 93 | + | |
| 94 | + | |
| 95 | + | |
| 96 | + | |
77 | 97 | | |
78 | 98 | | |
79 | | - | |
80 | | - | |
| 99 | + | |
| 100 | + | |
| 101 | + | |
| 102 | + | |
| 103 | + | |
| 104 | + | |
| 105 | + | |
| 106 | + | |
| 107 | + | |
81 | 108 | | |
82 | 109 | | |
83 | 110 | | |
| |||
90 | 117 | | |
91 | 118 | | |
92 | 119 | | |
93 | | - | |
94 | | - | |
| 120 | + | |
| 121 | + | |
| 122 | + | |
| 123 | + | |
| 124 | + | |
95 | 125 | | |
96 | 126 | | |
97 | 127 | | |
98 | 128 | | |
99 | | - | |
100 | | - | |
| 129 | + | |
| 130 | + | |
| 131 | + | |
| 132 | + | |
| 133 | + | |
101 | 134 | | |
102 | 135 | | |
103 | 136 | | |
| |||
0 commit comments