Speed up length of text strings#417
Merged
Merged
Conversation
length of valid UTF-8 text strings, take 2.length of text strings
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is an improved version of #394 which does not use
core::str::from_utf8, but rather implements the same technique as in BurntSushi/bstr#223. That should allow it to achieve much more stable results for strings that contain a few invalid UTF-8 sequences, but which are still mostly valid UTF-8.Furthermore, this removes a few casts for length calculation, which previously could truncate the length of very large strings.
Results:
In the pure ASCII case, calculating string length is now up to 16 times faster than in
main.