resolve nullability lint warnings

Author: 05nelsonm

topl-core-base/src/main/java/io/matthewnelson/topl_core_base/TorConfigFiles.kt

@@ -81,7 +81,7 @@ class TorConfigFiles private constructor(
      * @return [cookieAuthFile]
      * */
     val cookieAuthFile: File,
-    val libraryPath: File,
+    val libraryPath: File?,
     val resolveConf: File,
     val controlPortFile: File,
     val installDir: File,
@@ -191,7 +191,7 @@ class TorConfigFiles private constructor(
         private lateinit var mTorrcFile: File
         private lateinit var mHiddenServiceDir: File
         private lateinit var mDataDir: File
-        private lateinit var mLibraryPath: File
+        private var mLibraryPath: File? = null
         private lateinit var mCookieAuthFile: File
         private lateinit var mHostnameFile: File
         private lateinit var mResolveConf: File
@@ -341,7 +341,7 @@ class TorConfigFiles private constructor(
             if (!::mDataDir.isInitialized)
                 mDataDir = File(configDir, ConfigFileName.DATA_DIR)
 
-            if (!::mLibraryPath.isInitialized)
+            if (mLibraryPath != null)
                 mLibraryPath = mTorExecutableFile.parentFile
 
             if (!::mHostnameFile.isInitialized)

topl-core/src/main/java/io/matthewnelson/topl_core/OnionProxyContext.kt

@@ -251,7 +251,8 @@ internal class OnionProxyContext(
     @Throws(RuntimeException::class, SecurityException::class)
     fun deleteDataDirExceptHiddenService() =
         synchronized(dataDirLock) {
-            for (file in torConfigFiles.dataDir.listFiles())
+            val listFiles = torConfigFiles.dataDir.listFiles() ?: return
+            for (file in listFiles)
                 if (file.isDirectory)
                     if (file.absolutePath != torConfigFiles.hiddenServiceDir.absolutePath)
                         FileUtilities.recursiveFileDelete(file)
@@ -266,7 +267,8 @@ internal class OnionProxyContext(
     @Throws(SecurityException::class)
     fun setHostnameDirPermissionsToReadOnly(): Boolean =
         synchronized(hostnameFileLock) {
-            FileUtilities.setToReadOnlyPermissions(torConfigFiles.hostnameFile.parentFile)
+            val parentFile = torConfigFiles.hostnameFile.parentFile ?: return false
+            FileUtilities.setToReadOnlyPermissions(parentFile)
         }
 
     ///////////
@@ -300,7 +302,7 @@ internal class OnionProxyContext(
 
     @Throws(SecurityException::class)
     private fun createNewFileIfDoesNotExist(file: File): Boolean {
-        if (!file.parentFile.exists() && !file.parentFile.mkdirs()) {
+        if (file.parentFile?.exists() != true && file.parentFile?.mkdirs() != true) {
             broadcastLogger.warn("Could not create ${file.nameWithoutExtension} parent directory")
             return false
         }

topl-core/src/main/java/io/matthewnelson/topl_core/OnionProxyManager.kt

@@ -253,7 +253,7 @@ class OnionProxyManager(
 
         // Use the control connection to update the Tor config
         val config = listOf(
-            "HiddenServiceDir ${hostnameFile.parentFile.absolutePath}",
+            "HiddenServiceDir ${hostnameFile.parentFile?.absolutePath}",
             "HiddenServicePort $hiddenServicePort 127.0.0.1:$localPort"
         )
 
@@ -267,7 +267,7 @@ class OnionProxyManager(
 
         // Wait for the hostname file to be created/updated
         if (!hostNameFileObserver.poll(HOSTNAME_TIMEOUT.toLong(), TimeUnit.SECONDS)) {
-            FileUtilities.listFilesToLog(hostnameFile.parentFile)
+            hostnameFile.parentFile?.let { FileUtilities.listFilesToLog(it) }
             throw RuntimeException("Wait for hidden service hostname file to be created expired.")
         }
 

topl-core/src/main/java/io/matthewnelson/topl_core/util/FileUtilities.kt

@@ -152,9 +152,11 @@ object FileUtilities {
 
     @Throws(SecurityException::class)
     fun listFilesToLog(f: File) {
-        if (f.isDirectory)
-            for (child in f.listFiles())
+        if (f.isDirectory) {
+            val listFiles = f.listFiles() ?: return
+            for (child in listFiles)
                 listFilesToLog(child)
+        }
     }
 
     @Throws(IOException::class, EOFException::class, SecurityException::class)
@@ -193,9 +195,11 @@ object FileUtilities {
 
     @Throws(SecurityException::class)
     fun recursiveFileDelete(fileOrDirectory: File) {
-        if (fileOrDirectory.isDirectory)
-            for (child in fileOrDirectory.listFiles())
+        if (fileOrDirectory.isDirectory) {
+            val listFiles = fileOrDirectory.listFiles() ?: return
+            for (child in listFiles)
                 recursiveFileDelete(child)
+        }
 
         if (fileOrDirectory.exists() && !fileOrDirectory.delete())
             throw RuntimeException("Could not delete directory ${fileOrDirectory.absolutePath}")