Skip to content

Use null character \u0000, instead of a space, when back-filling CharArray #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
05nelsonm merged 1 commit into from
Dec 11, 2025
Merged

Use null character \u0000, instead of a space, when back-filling CharArray #221

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions library/core/src/commonMain/kotlin/io/matthewnelson/encoding/core/Encoder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -223,7 +223,9 @@ public sealed class Encoder<C: EncoderDecoder.Config>(config: C): Decoder<C>(con
val sb = StringBuilder(maxSize)
encoder.encode(this, sb::append)
val result = sb.toString()
if (encoder.config.backFillBuffers) sb.wipe()
if (encoder.config.backFillBuffers) {
sb.wipe()
}
result
}
}
Expand All @@ -250,7 +252,7 @@ public sealed class Encoder<C: EncoderDecoder.Config>(config: C): Decoder<C>(con
if (i == maxSize) return@block a
val copy = a.copyOf(i)
if (encoder.config.backFillBuffers) {
a.fill(' ', 0, i)
a.fill('\u0000', 0, i)
}
copy
}
Expand Down
4 changes: 2 additions & 2 deletions library/core/src/commonMain/kotlin/io/matthewnelson/encoding/core/EncoderDecoder.kt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,8 +122,8 @@ public abstract class EncoderDecoder<C: EncoderDecoder.Config>(config: C): Encod
* data (e.g. a [StringBuilder], [CharArray], or [ByteArray]). Depending on the underlying
* encoding/decoding operation, such as an array over-allocation due to [encodeOutMaxSize]
* or [decodeOutMaxSize], those initially allocated buffers may not be returned as the
* function's result. Prior versions of this library always back-filled them with `0` or a
* space character, but that can be computationally expensive for large datasets and
* function's result. Prior versions of this library always back-filled them with `0` or the
* null character `\u0000`, but that can be computationally expensive for large datasets and
* potentially unnecessary if data is known to not be sensitive in nature.
*
* If `true`, any non-result buffer allocations are back-filled before being de-referenced
Expand Down