Skip to content

Commit de3beef

Browse files
manuzhangcodex
andauthored
refactor: remove map_contains_key serde (apache#4703)
Remove the unreachable MapContainsKey serde and registry entry now that Spark rewrites map_contains_key to ArrayContains(MapKeys(...), key) before Comet serialization. Co-authored-by: Codex <codex@openai.com>
1 parent ce4180b commit de3beef

2 files changed

Lines changed: 0 additions & 18 deletions

File tree

spark/src/main/scala/org/apache/comet/serde/QueryPlanSerde.scala

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,6 @@ object QueryPlanSerde extends Logging with CometExprShim with CometTypeShim {
175175
classOf[MapEntries] -> CometMapEntries,
176176
classOf[MapValues] -> CometMapValues,
177177
classOf[MapFromArrays] -> CometMapFromArrays,
178-
classOf[MapContainsKey] -> CometMapContainsKey,
179178
classOf[MapFromEntries] -> CometMapFromEntries,
180179
classOf[MapConcat] -> CometMapConcat,
181180
classOf[StringToMap] -> CometStrToMap,

spark/src/main/scala/org/apache/comet/serde/maps.scala

Lines changed: 0 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -118,23 +118,6 @@ object CometMapFromArrays extends CometExpressionSerde[MapFromArrays] {
118118
}
119119
}
120120

121-
object CometMapContainsKey extends CometExpressionSerde[MapContainsKey] {
122-
123-
override def convert(
124-
expr: MapContainsKey,
125-
inputs: Seq[Attribute],
126-
binding: Boolean): Option[ExprOuterClass.Expr] = {
127-
// Replace with array_has(map_keys(map), key)
128-
val mapExpr = exprToProtoInternal(expr.left, inputs, binding)
129-
val keyExpr = exprToProtoInternal(expr.right, inputs, binding)
130-
131-
val mapKeysExpr = scalarFunctionExprToProto("map_keys", mapExpr)
132-
133-
val mapContainsKeyExpr = scalarFunctionExprToProto("array_has", mapKeysExpr, keyExpr)
134-
optExprWithFallbackReason(mapContainsKeyExpr, expr, expr.children: _*)
135-
}
136-
}
137-
138121
object CometMapFromEntries
139122
extends CometScalarFunction[MapFromEntries]("map_from_entries")
140123
with CodegenDispatchFallback {

0 commit comments

Comments
 (0)