[Feat] Refactor repo with build tools#14
Open
gund wants to merge 2 commits into
Open
Conversation
7e4a903 to
5a399a0
Compare
Owner
|
That looks awesome! I'll review the changes once the weekend is over. |
5a399a0 to
39e780a
Compare
0x48piraj
requested changes
Oct 28, 2023
Owner
0x48piraj
left a comment
There was a problem hiding this comment.
Hey, I'm sorry but I got busy and didn't have time to review all of the code, it looks good but yesterday I updated the extension hastily fixing YouTube's new patch to make it work again smoothly.
Can you resolve the conflicts?
d845199 to
9ce81c8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #6
Closes #5
Following the conversation regarding the maintainability of this codebase, here are changes that address them all:
There are many changes so I would advice you to carefully review at least the main logic files in
libs/core.I would also strongly suggest adding a CI (Continuous Integration) to be able to constantly build extensions here in Github Actions and maybe even add an auto-release workflow to publish extensions automatically to respective stores.
And maybe adding some unit tests at least for the core logic would be great too.
For the future improvements I would also suggest dropping jQuery from UI and replacing it with something more modern like Bootstrap or similar.
Also it is probably a good idea to move out all the classes for adblocking into a config which could be fetched remotely so the extension does not have to be updated to pickup new config.
Please have a look and let me know what do you think.
Cheers!