refactor(provider): make optimistic arg optional

Author: marvin-kolja

packages/providers/interface/src/provider.ts

@@ -12,7 +12,12 @@ export abstract class StorageServiceProvider<ID> {
         expiresIn: ExpiresIn
     ): SignedUploadUrlRequest<ID>
 
-    abstract getData(fileId: ID, optimistic: boolean): GetDataRequest<ID>
+    /**
+     *
+     * @param fileId
+     * @param optimistic If true, the provider will return the data without checking the existence of the file
+     */
+    abstract getData(fileId: ID, optimistic?: boolean): GetDataRequest<ID>
 
     abstract delete(fileId: ID): DeleteRequest
 }

packages/providers/s3/src/provider.ts

@@ -117,7 +117,7 @@ export class S3Provider<ID> extends StorageServiceProvider<ID> {
         return []
     }
 
-    async getData(fileId: ID, optimistic: boolean): GetDataRequest<ID> {
+    async getData(fileId: ID, optimistic = false): GetDataRequest<ID> {
         // TODO: Refactor the file check
 
         const variants = await this.createFileUrls(fileId, optimistic)

packages/server/core/src/upload-wizard.ts

@@ -65,10 +65,7 @@ export class UploadWizard<ID = DefaultID> {
             throw new Error('Invalid confirm token')
         }
 
-        const { status } = await this.storageServiceProvider.getData(
-            imageId,
-            false
-        )
+        const { status } = await this.storageServiceProvider.getData(imageId)
 
         if (status === FileStatus.NOT_FOUND) {
             throw new Error('File not found')