feat: re-add tonic-web dependency (#786)

* feat: re-add `tonic-web`

* update `miden-base`

* review: add comments to explain `tonic_web::enable`

Author: tomyrd

Cargo.lock

@@ -159,7 +159,7 @@ pub async fn serve_stub(endpoint: &Url) -> anyhow::Result<()> {
 
     tonic::transport::Server::builder()
         .accept_http1(true)
-        .add_service(api_service)
+        .add_service(tonic_web::enable(api_service)) // tonic_web::enable is needed to support grpc-web calls
         .serve_with_incoming(TcpListenerStream::new(listener))
         .await
         .context("failed to serve stub RPC API")

bin/faucet/src/stub_rpc_api.rs

@@ -348,7 +348,7 @@ fn create_batch(txs: &[ProvenTransaction], block_ref: &BlockHeader) -> ProvenBat
         .collect();
     let input_notes = txs.iter().flat_map(|tx| tx.input_notes().iter().cloned()).collect();
     let output_notes = txs.iter().flat_map(|tx| tx.output_notes().iter().cloned()).collect();
-    ProvenBatch::new_unchecked(
+    ProvenBatch::new(
         BatchId::from_transactions(txs.iter()),
         block_ref.commitment(),
         block_ref.block_num(),
@@ -358,6 +358,7 @@ fn create_batch(txs: &[ProvenTransaction], block_ref: &BlockHeader) -> ProvenBat
         BlockNumber::from(u32::MAX),
         OrderedTransactionHeaders::new_unchecked(txs.iter().map(TransactionHeader::from).collect()),
     )
+    .unwrap()
 }
 
 /// For each pair of account and note, creates a transaction that consumes the note.

bin/stress-test/src/main.rs

@@ -2,13 +2,12 @@ use miden_block_prover::ProvenBlockError;
 use miden_node_proto::errors::ConversionError;
 use miden_node_utils::{ErrorReport, formatting::format_opt};
 use miden_objects::{
-    Digest, ProposedBatchError, ProposedBlockError,
+    Digest, ProposedBatchError, ProposedBlockError, ProvenBatchError,
     block::BlockNumber,
     note::{NoteId, Nullifier},
     transaction::TransactionId,
 };
 use miden_proving_service_client::RemoteProverError;
-use miden_tx_batch_prover::errors::ProvenBatchError;
 use thiserror::Error;
 use tokio::task::JoinError;
 

crates/block-producer/src/errors.rs

@@ -56,7 +56,7 @@ impl TransactionBatchConstructor for ProvenBatch {
             output_notes.extend(tx.output_notes().iter().cloned());
         }
 
-        ProvenBatch::new_unchecked(
+        ProvenBatch::new(
             BatchId::from_transactions(txs.iter().copied()),
             Digest::default(),
             BlockNumber::GENESIS,
@@ -68,6 +68,7 @@ impl TransactionBatchConstructor for ProvenBatch {
                 txs.into_iter().map(TransactionHeader::from).collect(),
             ),
         )
+        .unwrap()
     }
 
     fn from_notes_created(starting_account_index: u32, notes_per_tx: &[u64]) -> Self {

crates/block-producer/src/test_utils/batch.rs

@@ -23,6 +23,7 @@ miden-tx         = { workspace = true }
 tokio            = { workspace = true, features = ["macros", "net", "rt-multi-thread"] }
 tokio-stream     = { workspace = true, features = ["net"] }
 tonic            = { workspace = true }
+tonic-web        = { version = "0.12" }
 tracing          = { workspace = true }
 
 [dev-dependencies]

crates/rpc/Cargo.toml

@@ -46,7 +46,7 @@ impl Rpc {
     pub async fn serve(self) -> anyhow::Result<()> {
         tonic::transport::Server::builder()
             .accept_http1(true)
-            .add_service(self.api_service)
+            .add_service(tonic_web::enable(self.api_service))  // tonic_web::enable is needed to support grpc-web calls
             .serve_with_incoming(TcpListenerStream::new(self.listener))
             .await
             .context("failed to serve RPC API")