-
Notifications
You must be signed in to change notification settings - Fork 145
feat(standards): Add DelayedExecution (Timelocked Accounts) to AuthMultisigSmart
#3044
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
onurinanc
wants to merge
35
commits into
next
Choose a base branch
from
onur-multisig-smart-delayed-execution
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
35 commits
Select commit
Hold shift + click to select a range
40bbb1d
add delayed execution logic
onurinanc 1b10a8c
fix comments
onurinanc 70bf840
add PR to changelog
onurinanc d491005
Merge branch 'next' into onur-multisig-smart-delayed-execution
onurinanc d1857a2
fix missing comments
onurinanc 7e55100
Merge remote-tracking branch 'origin/onur-multisig-smart-delayed-exec…
onurinanc 136bea3
add tests
onurinanc d4bb726
add more tests
onurinanc 216f8f4
remove optional delayed execution
onurinanc 5c3ee65
merge next
onurinanc 4210460
nits
onurinanc 30787c3
remove apply_propose_expiration_delta
onurinanc 58a265e
update comments
onurinanc eef73f2
Merge branch 'next' into onur-multisig-smart-delayed-execution
onurinanc a99bb0b
skip tx-summary reconstruction in AuthRequest when a signature is pre…
onurinanc 7bb3658
refactor delayed execution proposals logic
onurinanc 3bce0a4
fix comments
onurinanc 60dba7d
fix comments
onurinanc dd44e96
merge next
onurinanc a611cc7
Merge remote-tracking branch 'origin/onur-multisig-smart-delayed-exec…
onurinanc 79ce84f
add timestamp assertions
onurinanc 1739f74
merge next
onurinanc 7df203c
Merge remote-tracking branch 'origin/next' into onur-multisig-smart-d…
onurinanc eefca72
use is_tx_proposed instead of compute_requires_delay
onurinanc 4473cfc
apply suggestions
onurinanc 9d13778
Merge remote-tracking branch 'origin/next' into onur-multisig-smart-d…
onurinanc ac19c45
add @account_procedure
onurinanc 602181c
clippy
onurinanc c176063
merge next
onurinanc c063086
apply suggestions
onurinanc efb0765
Merge branch 'next' into onur-multisig-smart-delayed-execution
onurinanc 6923e98
resolve conflicts
onurinanc 690ad7f
Merge remote-tracking branch 'origin/onur-multisig-smart-delayed-exec…
onurinanc 1492e5e
Merge branch 'next' into onur-multisig-smart-delayed-execution
bobbinth 5cc248f
chore: fix build
bobbinth File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -530,6 +530,29 @@ proc get_current_threshold_and_num_approvers | |
| # => [default_threshold, num_approvers] | ||
| end | ||
|
|
||
| #! Verifies the configured approver signatures over `MSG` and returns how many of them are valid. | ||
| #! | ||
| #! Thin wrapper over [`signature::verify_signatures`] that supplies this component's approver | ||
| #! public-key and scheme-id storage slots, so callers don't need to know the slot layout. It does | ||
| #! not enforce any threshold, the caller compares the returned count against the required threshold. | ||
| #! | ||
| #! Inputs: [num_of_approvers, MSG] | ||
| #! Outputs: [num_verified_signatures, MSG] | ||
| #! | ||
| #! Invocation: exec | ||
| pub proc verify_signatures | ||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. We could replace lines 847-854 with a call to this procedure - right? |
||
| # => [num_of_approvers, MSG] | ||
|
|
||
| push.APPROVER_PUBLIC_KEYS_SLOT[0..2] | ||
| # => [pub_key_slot_suffix, pub_key_slot_prefix, num_of_approvers, MSG] | ||
|
|
||
| push.APPROVER_SCHEME_ID_SLOT[0..2] | ||
| # => [scheme_id_slot_suffix, scheme_id_slot_prefix, pub_key_slot_suffix, pub_key_slot_prefix, num_of_approvers, MSG] | ||
|
|
||
| exec.::miden::standards::auth::signature::verify_signatures | ||
| # => [num_verified_signatures, MSG] | ||
| end | ||
|
|
||
| #! Returns the current threshold and num_approvers from `THRESHOLD_CONFIG_SLOT`. | ||
| #! | ||
| #! Inputs: [pad(16)] | ||
|
|
||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: We usually don't mention the exact error variants.