Skip to content

Update AuthRequest event to carry either signature or TX summary#3157

Merged
PhilippGackstatter merged 2 commits into
nextfrom
bobbin-tx-signature
Jun 29, 2026
Merged

Update AuthRequest event to carry either signature or TX summary#3157
PhilippGackstatter merged 2 commits into
nextfrom
bobbin-tx-signature

Conversation

@bobbinth

@bobbinth bobbinth commented Jun 28, 2026

Copy link
Copy Markdown
Contributor

This PR changes the structure of the AuthRequest event from:

AuthRequest {
    pub_key_commitment: PublicKeyCommitment,
    tx_summary: Option<TransactionSummary>,
    signature: Option<Vec<Felt>>,
}

To

AuthRequest {
    pub_key_commitment: PublicKeyCommitment,
    tx_summary_or_signature: TxSummaryOrSignature,
}

The intent here is to make it so that when a signature for a given message is already present in the advice provider, we do not require constructing the TX summary matching the specified message. This allows the code to verify signatures over arbitrary messages.

For more context see #3044 (comment).

@PhilippGackstatter PhilippGackstatter left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@onurinanc onurinanc left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@PhilippGackstatter PhilippGackstatter added this pull request to the merge queue Jun 29, 2026
@github-merge-queue github-merge-queue Bot removed this pull request from the merge queue due to failed status checks Jun 29, 2026
@PhilippGackstatter PhilippGackstatter added this pull request to the merge queue Jun 29, 2026
Merged via the queue into next with commit 1166644 Jun 29, 2026
20 checks passed
@PhilippGackstatter PhilippGackstatter deleted the bobbin-tx-signature branch June 29, 2026 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants