-
Notifications
You must be signed in to change notification settings - Fork 145
refactor(standards): Multisig Auth Component cycle-cost optimizations, comment fixes, and PROC_ROOT validation #3211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
7eae9cc
fix multisig getters call API
onurinanc f863f77
reduce cycle costs
onurinanc 273f8d4
correct stack-layout and advice-map comments
onurinanc 1a77fe5
warn that growing the signer set does not re-scale overrides
onurinanc 3207826
validate PROC_ROOT belongs to the account in set_procedure_threshold
onurinanc e137464
changelog
onurinanc 069028a
Merge remote-tracking branch 'origin/next' into refactor-multisig
onurinanc a3a2caf
apply suggestions
onurinanc 96368fc
Merge remote-tracking branch 'origin/next' into refactor-multisig
onurinanc 1abe0bb
lint
onurinanc 4ce5509
clarify auth_tx replay protection comes from assert_new_tx, not SALT
onurinanc 0b22e7a
remove unused @locals(1) from auth_tx
onurinanc f92d4d4
remove redundant dupw/dropw in tx_policy proc-call check
onurinanc 23f78ae
explain advice-loaded config is covered by ACCOUNT_DELTA_COMMITMENT
onurinanc 196cc11
rename assert_new_tx to record_and_assert_new_tx
onurinanc e8f3a20
fix inaccurate auth-component comments
onurinanc 690e3d4
assert reconciled threshold config before approver-map cleanup
onurinanc b0271a7
use truncate_stack in tests
onurinanc 4603e80
fix
onurinanc 220e61f
apply suggestions
onurinanc 6430320
merge next
onurinanc File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.