-
Notifications
You must be signed in to change notification settings - Fork 145
ci: upload pre-built artifacts #3213
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
TomasArrachea
wants to merge
5
commits into
next
Choose a base branch
from
tomasarrachea-assembled-artifacts
base: next
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+53
−2
Open
Changes from all commits
Commits
Show all changes
5 commits
Select commit
Hold shift + click to select a range
231b157
feat: upload pre-built .masp packages to GitHub release
TomasArrachea 989e084
chore: comment
TomasArrachea ae1bfa0
fix: zizmor warning
TomasArrachea 9ade58c
Merge branch 'next' into tomasarrachea-assembled-artifacts
TomasArrachea 6a9de6f
feat: remove generate-packages bin
TomasArrachea File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm concerned this could pick up previous build artifacts from the cache. Why not have the build script of the protocol/standards crates write the package output to
$CARGO_MANIFEST_DIR/../target/$PROFILE/<package>.masp(you may need to adjust the the number of../segments based on the folder hierarchy of each crate).Then you will always know that after building those crates, the
.maspfiles undertarget/$PROFILE/will be the exact ones you requested