feat: migrate protocol and standards to Package#3224
Open
TomasArrachea wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR ports to
mainthe changes from #3107 and #3094.This assembles the
miden-protocolandmiden-standardslibraries in build time, along with all account components. The resulting.maspfiles are accessible fromOUT_DIR. Also the packages can be accessed from Rust sinceimpl From<ProtocolLib> for Packageandimpl From<StandardsLib> for Packageare being introduced.This is not breaking, so a few changes had to be made from those PRs:
TransactionKernel::kernel() -> KernelLibraryis kept. Added aTransactionKernel::package() -> Arc<Package>method.$kernelnamespace for the kernel testing library: changed the namespacemiden::tx_kernel_coreto$kernel. All existing MASM code keeps working.use $kernel::accountetc.). The only imports kept on new paths are the modules that physically moved into themiden-protocol-utilslibrary.$kernel::account_idmodule re-exporting a few procedures frommiden::protocol_utils::account_id, restoring an export the old testing library had (it used to be copied into the kernel lib directory at build time).TODO: