(consensus/params): Set default value of BlobParams.maxBytes to 0#19
Merged
marcello33 merged 15 commits intoMay 20, 2025
Merged
Conversation
sergio-mena
reviewed
May 15, 2025
sergio-mena
reviewed
May 15, 2025
sergio-mena
reviewed
May 15, 2025
sergio-mena
reviewed
May 15, 2025
sergio-mena
reviewed
May 15, 2025
sergio-mena
reviewed
May 15, 2025
sergio-mena
reviewed
May 15, 2025
sergio-mena
reviewed
May 15, 2025
sergio-mena
reviewed
May 15, 2025
sergio-mena
reviewed
May 15, 2025
jmalicevic
commented
May 16, 2025
sergio-mena
reviewed
May 19, 2025
sergio-mena
reviewed
May 19, 2025
sergio-mena
reviewed
May 19, 2025
sergio-mena
reviewed
May 19, 2025
sergio-mena
reviewed
May 19, 2025
sergio-mena
reviewed
May 19, 2025
sergio-mena
reviewed
May 19, 2025
sergio-mena
reviewed
May 19, 2025
sergio-mena
reviewed
May 19, 2025
sergio-mena
reviewed
May 19, 2025
sergio-mena
reviewed
May 20, 2025
sergio-mena
reviewed
May 20, 2025
sergio-mena
reviewed
May 20, 2025
sergio-mena
left a comment
sergio-mena
left a comment
There was a problem hiding this comment.
Thanks a lot for your patience 🙏. I know sometimes you need a good deal of it to cope with my reviews.
Only one last comment, but it's just a matter of how far we want to go with checks. Up to you if you want to address it.
APPROVE (I'm approving here, as I can't hit the "Approve" below)
Co-authored-by: Sergio Mena <sergio@informal.systems>
Co-authored-by: Sergio Mena <sergio@informal.systems>
|
marcello33
approved these changes
May 20, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As initially blobs will be disabled it makes sense to have the blob max bytes set to be 0 by default. This way, when the feature is enabled, there needs to be a governence proposal to update the max bytes to be something > 0 and < 800kb.