From eb4c6fa4b96a9694d6d94645dfbec3390e6adbfc Mon Sep 17 00:00:00 2001 From: marcello33 Date: Wed, 18 Jun 2025 15:27:52 +0200 Subject: [PATCH 1/5] disable genesis related endpoints --- rpc/core/net.go | 3 +++ 1 file changed, 3 insertions(+) diff --git a/rpc/core/net.go b/rpc/core/net.go index a79e2eb76aa..16dd32728aa 100644 --- a/rpc/core/net.go +++ b/rpc/core/net.go @@ -97,6 +97,8 @@ func (env *Environment) UnsafeDialPeers( // Genesis returns genesis file. // More: https://docs.cometbft.com/v0.38.x/rpc/#/Info/genesis func (env *Environment) Genesis(*rpctypes.Context) (*ctypes.ResultGenesis, error) { + return nil, errors.New("endpoint is disabled due to large genesis file size") + if len(env.genChunks) > 1 { return nil, errors.New("genesis response is large, please use the genesis_chunked API instead") } @@ -105,6 +107,7 @@ func (env *Environment) Genesis(*rpctypes.Context) (*ctypes.ResultGenesis, error } func (env *Environment) GenesisChunked(_ *rpctypes.Context, chunk uint) (*ctypes.ResultGenesisChunk, error) { + return nil, errors.New("endpoint is disabled due to large genesis file size") if env.genChunks == nil { return nil, fmt.Errorf("service configuration error, genesis chunks are not initialized") } From 0b69fa6d298ed969abad6afb8291b709383a2f4e Mon Sep 17 00:00:00 2001 From: marcello33 Date: Wed, 18 Jun 2025 15:37:05 +0200 Subject: [PATCH 2/5] skip tests --- rpc/client/rpc_test.go | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/rpc/client/rpc_test.go b/rpc/client/rpc_test.go index 8832ef040c1..091cf4012e2 100644 --- a/rpc/client/rpc_test.go +++ b/rpc/client/rpc_test.go @@ -164,6 +164,8 @@ func TestHealth(t *testing.T) { } func TestGenesisAndValidators(t *testing.T) { + t.Skip("Skipping due to large genesis file size") + for i, c := range GetClients() { // make sure this is the right genesis file @@ -189,6 +191,8 @@ func TestGenesisAndValidators(t *testing.T) { } func TestGenesisChunked(t *testing.T) { + t.Skip("Skipping due to large genesis file size") + ctx, cancel := context.WithCancel(context.Background()) defer cancel() From 0db164957830acf9eccb5da75b9c551abcf00d28 Mon Sep 17 00:00:00 2001 From: marcello33 Date: Wed, 18 Jun 2025 15:40:44 +0200 Subject: [PATCH 3/5] disable lint for unreachable code --- rpc/core/net.go | 2 ++ 1 file changed, 2 insertions(+) diff --git a/rpc/core/net.go b/rpc/core/net.go index 16dd32728aa..9a789ced225 100644 --- a/rpc/core/net.go +++ b/rpc/core/net.go @@ -96,6 +96,7 @@ func (env *Environment) UnsafeDialPeers( // Genesis returns genesis file. // More: https://docs.cometbft.com/v0.38.x/rpc/#/Info/genesis +// nolint:govet func (env *Environment) Genesis(*rpctypes.Context) (*ctypes.ResultGenesis, error) { return nil, errors.New("endpoint is disabled due to large genesis file size") @@ -106,6 +107,7 @@ func (env *Environment) Genesis(*rpctypes.Context) (*ctypes.ResultGenesis, error return &ctypes.ResultGenesis{Genesis: env.GenDoc}, nil } +// nolint:govet func (env *Environment) GenesisChunked(_ *rpctypes.Context, chunk uint) (*ctypes.ResultGenesisChunk, error) { return nil, errors.New("endpoint is disabled due to large genesis file size") if env.genChunks == nil { From 9f4bd4f085f9524a4811570fcbeda2e50e5fb780 Mon Sep 17 00:00:00 2001 From: marcello33 Date: Wed, 18 Jun 2025 15:48:43 +0200 Subject: [PATCH 4/5] fix linter --- rpc/core/net.go | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/rpc/core/net.go b/rpc/core/net.go index 9a789ced225..0fe01b6015f 100644 --- a/rpc/core/net.go +++ b/rpc/core/net.go @@ -96,7 +96,7 @@ func (env *Environment) UnsafeDialPeers( // Genesis returns genesis file. // More: https://docs.cometbft.com/v0.38.x/rpc/#/Info/genesis -// nolint:govet +//nolint:govet func (env *Environment) Genesis(*rpctypes.Context) (*ctypes.ResultGenesis, error) { return nil, errors.New("endpoint is disabled due to large genesis file size") @@ -107,7 +107,7 @@ func (env *Environment) Genesis(*rpctypes.Context) (*ctypes.ResultGenesis, error return &ctypes.ResultGenesis{Genesis: env.GenDoc}, nil } -// nolint:govet +//nolint:govet func (env *Environment) GenesisChunked(_ *rpctypes.Context, chunk uint) (*ctypes.ResultGenesisChunk, error) { return nil, errors.New("endpoint is disabled due to large genesis file size") if env.genChunks == nil { From 3e625c5f66ce7a8fef1fc8bc694d4f0e85ab1b78 Mon Sep 17 00:00:00 2001 From: marcello33 Date: Wed, 18 Jun 2025 15:49:13 +0200 Subject: [PATCH 5/5] fix linter --- rpc/core/net.go | 1 + 1 file changed, 1 insertion(+) diff --git a/rpc/core/net.go b/rpc/core/net.go index 0fe01b6015f..12b91d992fc 100644 --- a/rpc/core/net.go +++ b/rpc/core/net.go @@ -96,6 +96,7 @@ func (env *Environment) UnsafeDialPeers( // Genesis returns genesis file. // More: https://docs.cometbft.com/v0.38.x/rpc/#/Info/genesis +// //nolint:govet func (env *Environment) Genesis(*rpctypes.Context) (*ctypes.ResultGenesis, error) { return nil, errors.New("endpoint is disabled due to large genesis file size")