Skip to content
This repository was archived by the owner on Oct 15, 2024. It is now read-only.

Commit 939cae1

Browse files
Steve KlebanoffDaniel Pyrathon
andauthored
fix: Fix parameters sent off to RFQT providers to be unescaped (#264)
* Update asset-swapper to one with RFQT fix * update yarn lock * toString sellAmount * update to new ref * updated packages Co-authored-by: Daniel Pyrathon <daniel@0x.org>
1 parent d83bbb1 commit 939cae1

3 files changed

Lines changed: 4 additions & 4 deletions

File tree

package.json

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@
125125
},
126126
"dependencies": {
127127
"@0x/assert": "^3.0.4",
128-
"@0x/asset-swapper": "0xProject/gitpkg-registry#0x-asset-swapper-v4.4.0-73c779c13",
128+
"@0x/asset-swapper": "0xProject/gitpkg-registry#0x-asset-swapper-v4.4.0-1511ef1a9",
129129
"@0x/connect": "^6.0.4",
130130
"@0x/contract-addresses": "0xProject/gitpkg-registry#0x-contract-addresses-v4.9.0-f14b6f2ba",
131131
"@0x/contract-wrappers": "0xProject/gitpkg-registry#0x-contract-wrappers-v13.6.3-f14b6f2ba",

test/rfqt_test.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -79,7 +79,7 @@ describe(SUITE_NAME, () => {
7979
requestParams: {
8080
sellTokenAddress: contractAddresses.etherToken,
8181
buyTokenAddress: contractAddresses.zrxToken,
82-
sellAmountBaseUnits: DEFAULT_SELL_AMOUNT,
82+
sellAmountBaseUnits: DEFAULT_SELL_AMOUNT.toString(),
8383
buyAmountBaseUnits: undefined,
8484
takerAddress,
8585
},

yarn.lock

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,9 +22,9 @@
2222
lodash "^4.17.11"
2323
valid-url "^1.0.9"
2424

25-
"@0x/asset-swapper@0xProject/gitpkg-registry#0x-asset-swapper-v4.4.0-73c779c13":
25+
"@0x/asset-swapper@0xProject/gitpkg-registry#0x-asset-swapper-v4.4.0-1511ef1a9":
2626
version "4.4.0"
27-
resolved "https://codeload.github.com/0xProject/gitpkg-registry/tar.gz/b48045a98140f5a93c2fab2c691979e35a9b0dbc"
27+
resolved "https://codeload.github.com/0xProject/gitpkg-registry/tar.gz/ddd0aa71054e7bee268e0179ac71879bc9329d0f"
2828
dependencies:
2929
"@0x/assert" "^3.0.7"
3030
"@0x/contract-addresses" "^4.9.0"

0 commit comments

Comments
 (0)