Skip to content

Commit 29dc100

Browse files
committed
Add note about approving Validator contracts with caution
1 parent b57e346 commit 29dc100

1 file changed

Lines changed: 2 additions & 0 deletions

File tree

v3/v3-specification.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1454,6 +1454,8 @@ contract IValidator {
14541454

14551455
When using this signature type, the [`Exchange`](#exchange) contract makes a `staticcall` to the `Validator` contract's `isValidSignature` method, which means that signature verification will fail and revert if the `Validator` attempts to update state. A successful call to `isValidSignature` should always return `0x20c13b0b`, which is equal to `bytes4(keccak256("isValidSignature(bytes,bytes)")`. See the [EIP-1271 usage](#eip-1271-usage) section for information on how data is encoded before calling `isValidSignature`.
14561456

1457+
NOTE: Approved `Validator` contracts should be 100% trusted. A `Validator` contract with a malicious or incorrectly implemented `isValidSignature` function can result in the loss of _all_ assets that are approved for trading within the protocol.
1458+
14571459
#### Errors
14581460

14591461
| Error | Condition |

0 commit comments

Comments
 (0)