HTTP/SSE auth hardening + MSVC heap exhaustion fix#10
Closed
Conversation
- Change from 3-way split (~1900 lines) to 6-way split (~750-825 lines) - Extract all helper functions into interactions_helpers.hpp - Remove monolithic interactions.cpp in favor of split parts - Each part contains ~27-28 tests - All 164 tests pass on Windows with smaller compilation units
- interactions_helpers.hpp now contains only forward declarations (92 lines) - interactions_helpers.cpp contains implementations (1825 lines) - Helpers compiled as static library, test parts link against it - This prevents MSVC from processing all helpers for each test file
Even the single helpers.cpp was causing heap exhaustion. Split into 5 parts to keep each file small enough for MSVC.
The 64-bit host compiler has more addressable memory than the 32-bit host, which helps avoid C1060 (out of heap space) errors when compiling template-heavy code like JSON object construction.
SSE tests can be flaky on CI when running in parallel due to port binding conflicts. Running them serially improves reliability.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan