MCP parity: request metadata and 165 interaction tests#11
Merged
Conversation
Comprehensive test coverage matching Python's test_server_interactions.py: - TestTools, TestToolParameters, TestOutputSchema, TestContentTypes - TestResource, TestResourceTemplates, TestResourceAnnotations - TestPrompts, TestPromptVariations, TestMeta - TestCapabilities, TestProgressAndNotifications, TestRootsNotification - TestCancelledNotification, TestLogging, TestImageContent - TestEmbeddedResource, TestToolInputValidation, TestResourceSubscribe - TestCompletionEdgeCases, TestBatchOperations, TestTransportEdgeCases - Unicode, pagination, large data, error handling, and edge cases Also fixes iterator dereference bug in client.hpp when accessing structuredContent without registered outputSchema.
The InitializeResult type is a typed struct, not JSON - use proper struct field access instead of JSON-style accessor methods.
0xeb
added a commit
that referenced
this pull request
Nov 28, 2025
Split tests/server/interactions.cpp (5,548 lines, 193KB) into 3 smaller files to avoid MSVC C1060 "compiler is out of heap space" error on GitHub Actions Windows CI. Issue: Windows CI failed at interactions.cpp:2307 with C1060 during both Debug and Release builds. The file was too large for MSVC to compile in CI's constrained environment, despite compiling fine locally with the same compiler version (MSVC 14.44.35207). Solution: Split into 3 parts following the same pattern as commit 54dc027 which explicitly "split large test files for maintainability": - interactions_part1.cpp (55 tests, 1,989 lines) - Core Tools/Resources/Prompts - interactions_part2.cpp (59 tests, 2,104 lines) - Data types/Validation - interactions_part3.cpp (50 tests, 1,741 lines) - Server capabilities/Notifications All 164 tests accounted for and passing locally (3/3 tests, 0.04s). Related: PR #11 (43e5e64) which introduced the large interactions.cpp file. This change maintains all test coverage while fixing Windows CI builds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan