Merged
Conversation
Remove problematic connection test that was causing macOS CI failures: - Removed immediate-cancel connection check (lines 51-67) - Increased server startup wait from 1s to 2s for macOS - Added 100ms delay before SSE thread connection attempts The test connection was canceling immediately (line 61 returned false) which caused connection handling errors on macOS that persisted into the actual test. This left the server in a bad state for subsequent POST and SSE connections. Fixes: #<issue>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The
fastmcpp_sse_servertest was failing on macOS CI (both Debug and Release) with connection errors:Tests passed on Ubuntu and Ubuntu ARM but consistently failed on macOS.
Root Cause
The test had a "connection readiness check" (lines 51-67) that:
false)Solution
Testing
Impact