Fixing lint errors in wdk package

corbanbrook · corbanbrook · commit ff722c9d148a · 2026-02-23T16:37:40.000-05:00
diff --git a/packages/wallet/core/src/state/sequence/index.ts b/packages/wallet/core/src/state/sequence/index.ts
@@ -191,7 +191,7 @@ export class Provider implements ProviderInterface {
           throw new Error(`unexpected compact sapient signature by ${signer}`)
       }
     } catch {
-      //
+      // ignore
     }
   }
 
@@ -228,7 +228,7 @@ export class Provider implements ProviderInterface {
           }
       }
     } catch {
-      //
+      // ignore
     }
   }
 
diff --git a/packages/wallet/wdk/eslint.config.js b/packages/wallet/wdk/eslint.config.js
@@ -1,4 +1,12 @@
 import { config as baseConfig } from '@repo/eslint-config/base'
 
 /** @type {import("eslint").Linter.Config} */
-export default baseConfig
+export default [
+  ...baseConfig,
+  {
+    // files: ['**/*.{test,spec}.ts'],
+    rules: {
+      '@typescript-eslint/no-explicit-any': 'off',
+    },
+  },
+]
diff --git a/packages/wallet/wdk/package.json b/packages/wallet/wdk/package.json
@@ -12,7 +12,7 @@
     "dev": "tsc --watch",
     "test": "vitest run && npm run test:ssr",
     "test:coverage": "vitest run --coverage",
-    "test:ssr": "node test/test-ssr-safety.mjs",
+    "test:ssr": "node test/test-ssr-safety.js",
     "typecheck": "tsc --noEmit",
     "clean": "rimraf dist",
     "lint": "eslint . --max-warnings 0"
diff --git a/packages/wallet/wdk/src/dbs/auth-commitments.ts b/packages/wallet/wdk/src/dbs/auth-commitments.ts
@@ -1,4 +1,4 @@
-import { Generic, Migration } from './generic.js'
+import { Generic } from './generic.js'
 import { IDBPDatabase, IDBPTransaction } from 'idb'
 
 const TABLE_NAME = 'auth-commitments'
diff --git a/packages/wallet/wdk/src/dbs/auth-keys.ts b/packages/wallet/wdk/src/dbs/auth-keys.ts
@@ -1,4 +1,4 @@
-import { Generic, Migration } from './generic.js'
+import { Generic } from './generic.js'
 import { IDBPDatabase, IDBPTransaction } from 'idb'
 import type { WdkEnv } from '../env.js'
 
diff --git a/packages/wallet/wdk/src/dbs/messages.ts b/packages/wallet/wdk/src/dbs/messages.ts
@@ -1,5 +1,5 @@
 import { Message } from '../sequence/types/message-request.js'
-import { Generic, Migration } from './generic.js'
+import { Generic } from './generic.js'
 import { IDBPDatabase, IDBPTransaction } from 'idb'
 
 const TABLE_NAME = 'messages'
diff --git a/packages/wallet/wdk/src/dbs/passkey-credentials.ts b/packages/wallet/wdk/src/dbs/passkey-credentials.ts
@@ -1,4 +1,4 @@
-import { Generic, Migration } from './generic.js'
+import { Generic } from './generic.js'
 import { IDBPDatabase, IDBPTransaction } from 'idb'
 import { Address } from 'ox'
 import { Extensions } from '@0xsequence/wallet-primitives'
diff --git a/packages/wallet/wdk/src/dbs/recovery.ts b/packages/wallet/wdk/src/dbs/recovery.ts
@@ -1,4 +1,4 @@
-import { Generic, Migration } from './generic.js'
+import { Generic } from './generic.js'
 import { QueuedRecoveryPayload } from '../sequence/types/recovery.js'
 import { IDBPDatabase, IDBPTransaction } from 'idb'
 
diff --git a/packages/wallet/wdk/src/dbs/signatures.ts b/packages/wallet/wdk/src/dbs/signatures.ts
@@ -1,5 +1,5 @@
 import { BaseSignatureRequest } from '../sequence/index.js'
-import { Generic, Migration } from './generic.js'
+import { Generic } from './generic.js'
 import { IDBPDatabase, IDBPTransaction } from 'idb'
 
 const TABLE_NAME = 'envelopes'
diff --git a/packages/wallet/wdk/src/dbs/transactions.ts b/packages/wallet/wdk/src/dbs/transactions.ts
@@ -1,5 +1,5 @@
 import { Transaction } from '../sequence/types/transaction-request.js'
-import { Generic, Migration } from './generic.js'
+import { Generic } from './generic.js'
 import { IDBPDatabase, IDBPTransaction } from 'idb'
 
 const TABLE_NAME = 'transactions'
diff --git a/packages/wallet/wdk/src/dbs/wallets.ts b/packages/wallet/wdk/src/dbs/wallets.ts
@@ -1,4 +1,4 @@
-import { Generic, Migration } from './generic.js'
+import { Generic } from './generic.js'
 import { Wallet } from '../sequence/types/wallet.js'
 import { IDBPDatabase, IDBPTransaction } from 'idb'
 
diff --git a/packages/wallet/wdk/src/identity/signer.ts b/packages/wallet/wdk/src/identity/signer.ts
@@ -1,6 +1,6 @@
-import { Address, Signature, Hex, Bytes, PersonalMessage } from 'ox'
+import { Address, Signature, Hex, Bytes } from 'ox'
 import { Signers, State, type CryptoLike } from '@0xsequence/wallet-core'
-import { IdentityInstrument, KeyType } from '@0xsequence/identity-instrument'
+import { IdentityInstrument } from '@0xsequence/identity-instrument'
 import { AuthKey } from '../dbs/auth-keys.js'
 import { Payload, Signature as SequenceSignature } from '@0xsequence/wallet-primitives'
 import * as Identity from '@0xsequence/identity-instrument'
@@ -61,7 +61,7 @@ export class IdentitySigner implements Signers.Signer {
     }
   }
 
-  async witness(stateWriter: State.Writer, wallet: Address.Address, extra?: Object): Promise<void> {
+  async witness(stateWriter: State.Writer, wallet: Address.Address, extra?: object): Promise<void> {
     const payload = Payload.fromMessage(
       Hex.fromString(
         JSON.stringify({
diff --git a/packages/wallet/wdk/src/sequence/handlers/authcode-pkce.ts b/packages/wallet/wdk/src/sequence/handlers/authcode-pkce.ts
@@ -1,4 +1,4 @@
-import { Hex, Address, Bytes } from 'ox'
+import { Hex, Bytes } from 'ox'
 import { Handler } from './handler.js'
 import * as Db from '../../dbs/index.js'
 import { Signatures } from '../signatures.js'
diff --git a/packages/wallet/wdk/src/sequence/handlers/devices.ts b/packages/wallet/wdk/src/sequence/handlers/devices.ts
@@ -13,7 +13,7 @@ export class DevicesHandler implements Handler {
     private readonly devices: Devices,
   ) {}
 
-  onStatusChange(cb: () => void): () => void {
+  onStatusChange(_cb: () => void): () => void {
     return () => {}
   }
 
diff --git a/packages/wallet/wdk/src/sequence/handlers/guard.ts b/packages/wallet/wdk/src/sequence/handlers/guard.ts
@@ -35,7 +35,7 @@ export class GuardHandler implements Handler {
     this.onPromptCode = undefined
   }
 
-  onStatusChange(cb: () => void): () => void {
+  onStatusChange(_cb: () => void): () => void {
     return () => {}
   }
 
@@ -87,8 +87,9 @@ export class GuardHandler implements Handler {
       address,
       handler: this,
       status: 'ready',
-      handle: () =>
-        new Promise(async (resolve, reject) => {
+      handle: () => {
+        // eslint-disable-next-line no-async-promise-executor
+        return new Promise(async (resolve, reject) => {
           try {
             const signature = await guard.signEnvelope(request.envelope)
             await this.signatures.addSignature(request.id, signature)
@@ -106,7 +107,8 @@ export class GuardHandler implements Handler {
               reject(e)
             }
           }
-        }),
+        })
+      },
     }
   }
 }
diff --git a/packages/wallet/wdk/src/sequence/handlers/identity.ts b/packages/wallet/wdk/src/sequence/handlers/identity.ts
@@ -1,4 +1,4 @@
-import { Hex, Bytes } from 'ox'
+import { Hex } from 'ox'
 import * as Db from '../../dbs/index.js'
 import * as Identity from '@0xsequence/identity-instrument'
 import { Signatures } from '../signatures.js'
diff --git a/packages/wallet/wdk/src/sequence/handlers/mnemonic.ts b/packages/wallet/wdk/src/sequence/handlers/mnemonic.ts
@@ -93,8 +93,9 @@ export class MnemonicHandler implements Handler {
       handler: this,
       status: 'actionable',
       message: 'enter-mnemonic',
-      handle: () =>
-        new Promise(async (resolve, reject) => {
+      handle: () => {
+        // eslint-disable-next-line no-async-promise-executor
+        return new Promise(async (resolve, reject) => {
           const respond: RespondFn = async (mnemonic) => {
             const signer = MnemonicHandler.toSigner(mnemonic)
             if (!signer) {
@@ -117,7 +118,8 @@ export class MnemonicHandler implements Handler {
             resolve(true)
           }
           await onPromptMnemonic(respond)
-        }),
+        })
+      },
     }
   }
 }
diff --git a/packages/wallet/wdk/src/sequence/handlers/otp.ts b/packages/wallet/wdk/src/sequence/handlers/otp.ts
@@ -85,7 +85,7 @@ export class OtpHandler extends IdentityHandler implements Handler {
         try {
           await this.handleAuth(challenge, onPromptOtp)
           return true
-        } catch (e) {
+        } catch {
           return false
         }
       },
@@ -96,6 +96,7 @@ export class OtpHandler extends IdentityHandler implements Handler {
     challenge: Identity.OtpChallenge,
     onPromptOtp: PromptOtpHandler,
   ): Promise<{ signer: Signers.Signer & Signers.Witnessable; email: string }> {
+    // eslint-disable-next-line no-async-promise-executor
     return new Promise(async (resolve, reject) => {
       try {
         const { loginHint, challenge: codeChallenge } = await this.nitroCommitVerifier(challenge)
diff --git a/packages/wallet/wdk/src/sequence/handlers/passkeys.ts b/packages/wallet/wdk/src/sequence/handlers/passkeys.ts
@@ -18,7 +18,7 @@ export class PasskeysHandler implements Handler {
     private readonly passkeyProvider: PasskeyProvider,
   ) {}
 
-  onStatusChange(cb: () => void): () => void {
+  onStatusChange(_cb: () => void): () => void {
     return () => {}
   }
 
diff --git a/packages/wallet/wdk/src/sequence/handlers/recovery.ts b/packages/wallet/wdk/src/sequence/handlers/recovery.ts
@@ -76,7 +76,7 @@ export class RecoveryHandler implements Handler {
           return true
         },
       }
-    } catch (e) {
+    } catch {
       return {
         address,
         handler: this,
diff --git a/packages/wallet/wdk/src/sequence/manager.ts b/packages/wallet/wdk/src/sequence/manager.ts
@@ -561,7 +561,7 @@ export class Manager {
     const ops = applyManagerOptionsDefaults(options)
 
     // Build relayers list
-    let relayers: Relayer.Relayer[] = []
+    const relayers: Relayer.Relayer[] = []
 
     // Add EIP-6963 relayers if enabled
     if (ops.multiInjectedProviderDiscovery) {
diff --git a/packages/wallet/wdk/src/sequence/messages.ts b/packages/wallet/wdk/src/sequence/messages.ts
@@ -242,7 +242,7 @@ export class Messages implements MessagesInterface {
       const message = await this.getByMessageOrSignatureId(messageOrSignatureId)
       await this.shared.databases.signatures.del(message.signatureId)
       await this.shared.databases.messages.del(message.id)
-    } catch (error) {
+    } catch {
       // Ignore
     }
   }
diff --git a/packages/wallet/wdk/src/sequence/signers.ts b/packages/wallet/wdk/src/sequence/signers.ts
@@ -81,7 +81,9 @@ export class Signers {
       if (isWitnessExtraSignerKind(message)) {
         return toKnownKind(message.signerKind)
       }
-    } catch {}
+    } catch {
+      // ignore
+    }
 
     return undefined
   }
diff --git a/packages/wallet/wdk/src/sequence/transactions.ts b/packages/wallet/wdk/src/sequence/transactions.ts
@@ -496,7 +496,7 @@ export class Transactions implements TransactionsInterface {
     let tx: Transaction | undefined
     try {
       tx = await this.get(transactionOrSignatureId)
-    } catch (e) {
+    } catch {
       // If not found, it might be a signature ID
       const signature = await this.shared.modules.signatures.get(transactionOrSignatureId)
       if (!signature) {
diff --git a/packages/wallet/wdk/src/sequence/wallets.ts b/packages/wallet/wdk/src/sequence/wallets.ts
@@ -1,17 +1,16 @@
 import { Wallet as CoreWallet, Envelope, Signers, State } from '@0xsequence/wallet-core'
-import { Config, Constants, GenericTree, Payload, SessionConfig } from '@0xsequence/wallet-primitives'
+import { Config, Constants, Payload } from '@0xsequence/wallet-primitives'
 import { Address, Hex, Provider, RpcTransport } from 'ox'
 import { AuthCommitment } from '../dbs/auth-commitments.js'
 import { AuthCodeHandler } from './handlers/authcode.js'
 import { MnemonicHandler } from './handlers/mnemonic.js'
 import { OtpHandler } from './handlers/otp.js'
-import { ManagerOptionsDefaults, Shared } from './manager.js'
+import { Shared } from './manager.js'
 import { Device } from './types/device.js'
 import { Action, Module } from './types/index.js'
 import { Kinds, SignerWithKind, WitnessExtraSignerKind } from './types/signer.js'
 import { Wallet, WalletSelectionUiHandler } from './types/wallet.js'
 import { PasskeysHandler } from './handlers/passkeys.js'
-import { GuardRole } from './guards.js'
 import type { PasskeySigner } from './passkeys-provider.js'
 
 export type StartSignUpWithRedirectArgs = {
@@ -418,17 +417,17 @@ function buildCappedTree(members: { address: Address.Address; imageHash?: Hex.He
   } as Config.NestedLeaf
 }
 
-function buildCappedTreeFromTopology(weight: bigint, topology: Config.Topology): Config.Topology {
-  // We may optimize this for some topology types
-  // but it is not worth it, because the topology
-  // that we will use for prod won't be optimizable
-  return {
-    type: 'nested',
-    weight: weight,
-    threshold: weight,
-    tree: topology,
-  }
-}
+// function buildCappedTreeFromTopology(weight: bigint, topology: Config.Topology): Config.Topology {
+//   // We may optimize this for some topology types
+//   // but it is not worth it, because the topology
+//   // that we will use for prod won't be optimizable
+//   return {
+//     type: 'nested',
+//     weight: weight,
+//     threshold: weight,
+//     tree: topology,
+//   }
+// }
 
 function toConfig(
   checkpoint: bigint,
@@ -626,7 +625,7 @@ export class Wallets implements WalletsInterface {
     loginEmail?: string
   }> {
     switch (args.kind) {
-      case 'passkey':
+      case 'passkey': {
         const passkeySigner = await this.shared.passkeyProvider.create(this.shared.sequence.extensions, {
           stateProvider: this.shared.sequence.stateProvider,
           credentialName: args.name,
@@ -639,8 +638,9 @@ export class Wallets implements WalletsInterface {
             signerKind: Kinds.LoginPasskey,
           },
         }
+      }
 
-      case 'mnemonic':
+      case 'mnemonic': {
         const mnemonicSigner = MnemonicHandler.toSigner(args.mnemonic)
         if (!mnemonicSigner) {
           throw new Error('invalid-mnemonic')
@@ -654,6 +654,7 @@ export class Wallets implements WalletsInterface {
             signerKind: Kinds.LoginMnemonic,
           },
         }
+      }
 
       case 'email-otp': {
         const handler = this.shared.handlers.get(Kinds.LoginEmailOtp) as OtpHandler
@@ -835,7 +836,7 @@ export class Wallets implements WalletsInterface {
     const sessionsGuardTopology = args.noGuard ? undefined : this.shared.modules.guards.topology('sessions')
 
     // Add modules
-    let modules: Module[] = []
+    const modules: Module[] = []
 
     if (!args.noSessionManager) {
       const identitySigners = [device.address]
@@ -1044,8 +1045,6 @@ export class Wallets implements WalletsInterface {
         })
 
         return requestId
-      } catch (error) {
-        throw error
       } finally {
         this.pendingMnemonicOrPasskeyLogin = undefined
       }
@@ -1235,7 +1234,7 @@ export class Wallets implements WalletsInterface {
     return requestId
   }
 
-  async completeLogout(requestId: string, options?: { skipValidateSave?: boolean }) {
+  async completeLogout(requestId: string, _options?: { skipValidateSave?: boolean }) {
     const request = await this.shared.modules.signatures.get(requestId)
     const walletEntry = await this.shared.databases.manager.get(request.wallet)
     if (!walletEntry) {
diff --git a/packages/wallet/wdk/test/authcode-pkce.test.ts b/packages/wallet/wdk/test/authcode-pkce.test.ts
@@ -1,5 +1,4 @@
 import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest'
-import { Address, Hex, Bytes } from 'ox'
 import * as Identity from '@0xsequence/identity-instrument'
 import { AuthCodePkceHandler } from '../src/sequence/handlers/authcode-pkce.js'
 import { Signatures } from '../src/sequence/signatures.js'
@@ -68,15 +67,15 @@ describe('AuthCodePkceHandler', () => {
     handler.setRedirectUri('https://example.com/auth/callback')
 
     // Mock inherited methods
-    vi.spyOn(handler as any, 'nitroCommitVerifier').mockImplementation(async (challenge) => {
+    vi.spyOn(handler as any, 'nitroCommitVerifier').mockImplementation(async () => {
       return {
         verifier: 'mock-verifier-code',
         loginHint: 'user@example.com',
         challenge: 'mock-challenge-hash',
       }
     })
 
-    vi.spyOn(handler as any, 'nitroCompleteAuth').mockImplementation(async (challenge) => {
+    vi.spyOn(handler as any, 'nitroCompleteAuth').mockImplementation(async () => {
       return {
         signer: mockIdentitySigner,
         email: 'user@example.com',
diff --git a/packages/wallet/wdk/test/authcode.test.ts b/packages/wallet/wdk/test/authcode.test.ts
diff --git a/packages/wallet/wdk/test/constants.ts b/packages/wallet/wdk/test/constants.ts
diff --git a/packages/wallet/wdk/test/guard.test.ts b/packages/wallet/wdk/test/guard.test.ts
diff --git a/packages/wallet/wdk/test/identity-signer.test.ts b/packages/wallet/wdk/test/identity-signer.test.ts
diff --git a/packages/wallet/wdk/test/otp.test.ts b/packages/wallet/wdk/test/otp.test.ts
diff --git a/packages/wallet/wdk/test/passkeys.test.ts b/packages/wallet/wdk/test/passkeys.test.ts
diff --git a/packages/wallet/wdk/test/recovery.test.ts b/packages/wallet/wdk/test/recovery.test.ts
diff --git a/packages/wallet/wdk/test/sessions.test.ts b/packages/wallet/wdk/test/sessions.test.ts
diff --git a/packages/wallet/wdk/test/test-ssr-safety.js b/packages/wallet/wdk/test/test-ssr-safety.js
diff --git a/packages/wallet/wdk/test/transactions.test.ts b/packages/wallet/wdk/test/transactions.test.ts
diff --git a/packages/wallet/wdk/test/wallets.test.ts b/packages/wallet/wdk/test/wallets.test.ts
diff --git a/turbo.json b/turbo.json

Original file line number	Diff line number	Diff line change
`@@ -191,7 +191,7 @@ export class Provider implements ProviderInterface {`
`191`	`191`	throw new Error(`unexpected compact sapient signature by ${signer}`)
`192`	`192`	`}`
`193`	`193`	`} catch {`
`194`		`- //`
	`194`	`+ // ignore`
`195`	`195`	`}`
`196`	`196`	`}`
`197`	`197`
`@@ -228,7 +228,7 @@ export class Provider implements ProviderInterface {`
`228`	`228`	`}`
`229`	`229`	`}`
`230`	`230`	`} catch {`
`231`		`- //`
	`231`	`+ // ignore`
`232`	`232`	`}`
`233`	`233`	`}`
`234`	`234`
Original file line number	Diff line number	Diff line change
`@@ -1,4 +1,4 @@`
`1`		`-import { Generic, Migration } from './generic.js'`
	`1`	`+import { Generic } from './generic.js'`
`2`	`2`	`import { IDBPDatabase, IDBPTransaction } from 'idb'`
`3`	`3`
`4`	`4`	`const TABLE_NAME = 'auth-commitments'`