fix: APD-1031 beetleIcon="hide" not working in opc-feedback component#905
Closed
shwaghma wants to merge 3 commits into
Closed
fix: APD-1031 beetleIcon="hide" not working in opc-feedback component#905shwaghma wants to merge 3 commits into
shwaghma wants to merge 3 commits into
Conversation
deshmukhmayur
requested changes
Jul 28, 2025
Member
There was a problem hiding this comment.
@shwaghma As this PR only contains changes for the opc-feedback component, can you revert this file?
Comment on lines
-167
to
-190
| get renderIcon() { | ||
| if(this.beetleIcon !== "hide"){ | ||
| const isModelOpen = | ||
| this._openFeedbackModal || | ||
| this._openConfirmationModal || | ||
| this._openInitialModal || | ||
| this._openBugModal; | ||
| if (!isModelOpen) { | ||
| return html`<img | ||
| src=${beetleIcon} | ||
| width="20px" | ||
| height="20px" | ||
| id="beetleIcon" | ||
| alt="beetle" | ||
| class="pf-u-mr-xs" | ||
| />`; | ||
| } | ||
| return html`<ion-icon | ||
| name="${isModelOpen ? 'ellipsis-horizontal-outline' : 'chatbox-ellipses'}" | ||
| class="pf-u-font-size-xl pf-u-mr-xs" | ||
| > | ||
| </ion-icon>`; | ||
| } | ||
| } |
Member
There was a problem hiding this comment.
@shwaghma the issue is to fix the problem with the beetleIcon="hide".
This will just remove the icon completely.
This is a reusable web component, where the adopters can choose to show/hide it depending on their use case.
Can you revert this and look into the issue where they are not able to hide the icon?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.