fix: 🐛 Unable to call unlock in a module in use

Author: remimd

injection/_core/module.py

@@ -156,6 +156,12 @@ def __str__(self) -> str:
         )
 
 
+@dataclass(frozen=True, slots=True)
+class UnlockCalled(Event):
+    def __str__(self) -> str:
+        return "An `unlock` method has been called."
+
+
 """
 Broker
 """
@@ -179,7 +185,7 @@ def is_locked(self) -> bool:
         raise NotImplementedError
 
     @abstractmethod
-    def unlock(self) -> Self:
+    def unsafe_unlocking(self) -> None:
         raise NotImplementedError
 
     @abstractmethod
@@ -289,12 +295,10 @@ def update[T](self, updater: Updater[T]) -> Self:
 
         return self
 
-    def unlock(self) -> Self:
+    def unsafe_unlocking(self) -> None:
         for injectable in self.__injectables:
             injectable.unlock()
 
-        return self
-
     async def all_ready(self) -> None:
         for injectable in self.__injectables:
             if injectable.is_locked:
@@ -802,11 +806,17 @@ def change_priority(self, module: Module, priority: Priority | PriorityStr) -> S
         return self
 
     def unlock(self) -> Self:
-        for broker in self.__brokers:
-            broker.unlock()
+        event = UnlockCalled()
+
+        with self.dispatch(event, lock_bypass=True):
+            self.unsafe_unlocking()
 
         return self
 
+    def unsafe_unlocking(self) -> None:
+        for broker in self.__brokers:
+            broker.unsafe_unlocking()
+
     def load_profile(self, *names: str) -> ContextManager[Self]:
         modules = (self.from_name(name) for name in names)
         self.unlock().init_modules(*modules)
@@ -839,8 +849,9 @@ def on_event(self, event: Event, /) -> ContextManager[None]:
         return self.dispatch(self_event)
 
     @contextmanager
-    def dispatch(self, event: Event) -> Iterator[None]:
-        self.__check_locking()
+    def dispatch(self, event: Event, *, lock_bypass: bool = False) -> Iterator[None]:
+        if not lock_bypass:
+            self.__check_locking()
 
         with self.__channel.dispatch(event):
             try:

tests/core/test_module.py

@@ -422,8 +422,6 @@ class B: ...
         assert a is not module.get_instance(A)
         assert b is not module.get_instance(B)
 
-    # TODO: not yet implemented
-    @pytest.mark.skip
     def test_unlock_with_module_in_use_raise_module_lock_error(self, module):
         second_module = Module()
         module.use(second_module)