Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR renames the module reference from "injection.utils" to "injection.loaders" across tests, documentation, and core setup files for improved naming clarity.
- Updated test files to import from "injection.loaders"
- Modified documentation to reflect the new module naming
- Adjusted conftest and internal module files accordingly, with changes in FastAPI extension files also addressing type handling
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| tests/utils/test_python_module_loader.py | Updated import from "injection.utils" to "injection.loaders". |
| tests/utils/test_load_profile.py | Updated import from "injection.utils" to "injection.loaders". |
| injection/testing/init.py | Updated import from "injection.utils" to "injection.loaders". |
| injection/ext/fastapi.pyi | Added new file for FastAPI type annotations using collection patterns. |
| injection/ext/fastapi.py | Removed the TYPE_CHECKING branch for Inject type alias in favor of a runtime alias. |
| documentation/utils.md | Updated code examples to use "injection.loaders" instead of "injection.utils". |
| conftest.py | Updated import from "injection.utils" to "injection.loaders". |
Comments suppressed due to low confidence (1)
injection/ext/fastapi.py:33
- The removal of the TYPE_CHECKING branch for providing a type alias for 'Inject' may impact static analysis. Consider retaining or updating explicit type hints to ensure tooling support remains robust.
if TYPE_CHECKING:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.