Skip to content

feat: ✨ load_profile method for entrypoint#239

Merged
remimd merged 1 commit intodevfrom
load_profile
May 12, 2025
Merged

feat: ✨ load_profile method for entrypoint#239
remimd merged 1 commit intodevfrom
load_profile

Conversation

@remimd
Copy link
Copy Markdown
Member

@remimd remimd commented May 12, 2025

No description provided.

@remimd remimd requested a review from Copilot May 12, 2025 23:22
@remimd remimd self-assigned this May 12, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces a new load_profile method for Entrypoint and a corresponding test to verify its behavior. The key changes are:

  • Added a new test case for load_profile in tests/entrypoint/test_entrypoint.py.
  • Implemented the load_profile method in injection/entrypoint.py.
  • Renamed a helper context manager from "cleaner" to "unload" in injection/_core/module.py.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/entrypoint/test_entrypoint.py Added a test case to verify load_profile behavior.
injection/entrypoint.py Added the load_profile method using a contextmanager wrapper.
injection/_core/module.py Renamed the contextmanager helper from "cleaner" to "unload".
Comments suppressed due to low confidence (1)

injection/_core/module.py:819

  • [nitpick] The renaming of the context manager helper from 'cleaner' to 'unload' may reduce clarity on its purpose. Consider either reverting to the original name or adding a clarifying comment to explain the intent of 'unload'.
def unload() -> Iterator[Self]:

@remimd remimd merged commit bb3e8dc into dev May 12, 2025
5 checks passed
@remimd remimd deleted the load_profile branch May 12, 2025 23:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants