Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new ProfileLoader-based API for loading profiles, replacing the previous signature using module-based profiles. Key changes include:
- Updating load_test_profile in testing modules to accept a ProfileLoader.
- Refactoring the loaders and entrypoint modules to utilize ProfileLoader and LoadedProfile protocols.
- Removing the old load_profile method from Module and its type declaration in init.pyi.
Reviewed Changes
Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| injection/testing/init.pyi | Updated imports and function signature for testing profiles |
| injection/testing/init.py | Updated function signature and parameters for testing profiles |
| injection/loaders.py | Added ProfileLoader and LoadedProfile along with associated methods |
| injection/entrypoint.py | Replaced module-based profile handling with ProfileLoader and updated the decorator logic |
| injection/_core/module.py | Removed the obsolete load_profile function |
| injection/init.pyi | Removed load_profile declaration to reflect API changes |
| documentation/entrypoint.md | Minor text update in description |
Comments suppressed due to low confidence (1)
injection/testing/init.pyi:15
- The default value for the loader parameter is specified as '...', while in the .py file it defaults to None. Consider aligning these defaults for consistency.
def load_test_profile(loader: ProfileLoader = ...):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.