Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR makes ScopeFacade thread-safe by introducing a shared lock for binding and slot updates.
- Pass a
lockinto_UserScopeand use it to guardslot_mapoperations - Inline the binder context call and preserve locking for unbinding
Comments suppressed due to low confidence (2)
injection/_core/scope.py:327
- [nitpick] The attribute name
lockis generic and may collide with other variables; consider renaming to_scope_lockor similar to clarify its purpose and mark it as internal.
lock: ContextManager[Any]
injection/_core/scope.py:335
- There are no tests covering concurrent calls to
slot_map. Adding a test that runsslot_mapfrom multiple threads would help ensure the new locking logic behaves correctly under contention.
with self.lock:
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.