Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new parameter, threadsafe, to the LazyInstance functionality in order to allow clients to opt‑in to using thread‑safe lazy initialization via the module’s get_lazy_instance API.
- Added a threadsafe parameter (defaulting to False) to the LazyInstance implementation in descriptors and its type signatures in the stubs
- Updated the basic usage documentation to reflect the use of threading.RLock for threadsafe injection
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| injection/_core/descriptors.py | Updated init to pass the new threadsafe flag |
| injection/init.pyi | Adjusted LazyInstance type annotations to include threadsafe |
| documentation/basic-usage.md | Modified documentation to note that RLock is now used |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.