Conversation
There was a problem hiding this comment.
Pull Request Overview
Refactors semaphore creation into a unified AsyncSemaphore alias, cleans up the FastAPI injection helper, and adjusts the scoped method signature in the module stub.
- Consolidate semaphore factories into a single
AsyncSemaphorealias - Rename and re-type FastAPI dependency helper variables
- Simplify
Module.scopedgeneric parameters in the.pyistub
Reviewed Changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| injection/ext/fastapi.py | Renamed ainstance to lazy_instance and added TypeAlias import |
| injection/_core/injectables.py | Replaced _create_async_semaphore with AsyncSemaphore |
| injection/_core/common/asynchronous.py | Removed standalone factory functions and defined AsyncSemaphore alias |
| injection/init.pyi | Updated scoped signature to drop **P generics |
Comments suppressed due to low confidence (1)
injection/init.pyi:152
- Dropping the
**Pgeneric parameters reduces the method’s flexibility for factories that take arguments; consider restoringdef scoped[**P, T]to preserve full type inference.
def scoped[T](
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.