Skip to content

rename: ✏️ @asfunction call method#261

Merged
remimd merged 1 commit intodevfrom
asfunction
Jun 7, 2025
Merged

rename: ✏️ @asfunction call method#261
remimd merged 1 commit intodevfrom
asfunction

Conversation

@remimd
Copy link
Copy Markdown
Member

@remimd remimd commented Jun 7, 2025

No description provided.

@remimd remimd requested a review from Copilot June 7, 2025 15:48
@remimd remimd self-assigned this Jun 7, 2025
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR renames the method used by the asfunction decorator from call to call, aligning the implementation, tests, and documentation with the updated design.

  • Renames call to call in both synchronous and asynchronous function wrappers.
  • Updates tests to validate the new method name.
  • Revises documentation examples to reflect the change.

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
tests/core/test_asfunction.py Renames call to call in test case definitions.
injection/_core/asfunction.py Replaces call invocation with call in function wrapper.
documentation/integrations/unlisted-framework.md Updates documentation examples to use call instead of call.
Comments suppressed due to low confidence (3)

tests/core/test_asfunction.py:15

  • The method is renamed to 'call'. Please verify that any test invocations expecting the old 'call' are updated accordingly.
def call(self):

injection/_core/asfunction.py:46

  • Ensure that updating the method reference from 'call' to 'call' aligns with the intended API design and that all dependent functionality is adjusted accordingly.
return await self.call(*args, **kwargs)  # type: ignore[misc]

documentation/integrations/unlisted-framework.md:31

  • [nitpick] The documentation example now uses 'call' instead of 'call'; please ensure that the narrative clearly explains this updated convention for dependency injection.
def call(self):

@remimd remimd merged commit ff34de7 into dev Jun 7, 2025
5 checks passed
@remimd remimd deleted the asfunction branch June 7, 2025 15:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants