Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR renames the method used by the asfunction decorator from call to call, aligning the implementation, tests, and documentation with the updated design.
- Renames call to call in both synchronous and asynchronous function wrappers.
- Updates tests to validate the new method name.
- Revises documentation examples to reflect the change.
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| tests/core/test_asfunction.py | Renames call to call in test case definitions. |
| injection/_core/asfunction.py | Replaces call invocation with call in function wrapper. |
| documentation/integrations/unlisted-framework.md | Updates documentation examples to use call instead of call. |
Comments suppressed due to low confidence (3)
tests/core/test_asfunction.py:15
- The method is renamed to 'call'. Please verify that any test invocations expecting the old 'call' are updated accordingly.
def call(self):
injection/_core/asfunction.py:46
- Ensure that updating the method reference from 'call' to 'call' aligns with the intended API design and that all dependent functionality is adjusted accordingly.
return await self.call(*args, **kwargs) # type: ignore[misc]
documentation/integrations/unlisted-framework.md:31
- [nitpick] The documentation example now uses 'call' instead of 'call'; please ensure that the narrative clearly explains this updated convention for dependency injection.
def call(self):
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.