Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR improves the decorator type hints and overloads for various dependency injection decorators.
- Introduces overloads for the autocall decorator in injection/entrypoint.py.
- Replaces Iterable with Sequence in the type definitions and updates overload signatures for inject, injectable, singleton, and constant in init.pyi.
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| injection/entrypoint.py | Updated autocall decorator with overloads and type annotations. |
| injection/_core/common/type.py | Replaces Iterable with Sequence in type hints for TypeInfo. |
| injection/init.pyi | Adds multiple overloads with improved type hints for dependency injection decorators. |
Comments suppressed due to low confidence (2)
injection/entrypoint.py:38
- The autocall decorator's inner function calls wp() without parameters, which assumes that the wrapped function takes no arguments. Consider clarifying this behavior in the documentation or enforcing that only parameterless functions are allowed.
wp()
injection/_core/common/type.py:30
- Replacing Iterable with Sequence may restrict acceptable input types. Confirm that this change aligns with the intended use cases, especially if lazy evaluation is expected in some scenarios.
| Sequence[TypeInfo[T]]
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.