Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR applies small refactorings to the injection core modules, updates yield‐hint extraction behavior, and tweaks the type stub for inject.
- Simplify override logic and refactor the
onparameter construction in the decorator ofmodule.py - Change
get_yield_hintto always return a tuple of yielded types and update its annotation - Add a blank line in the
injectoverload in the.pyistub
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| injection/_core/module.py | Refactored __keep_new_record override logic; adjusted hint/on handling in decorator |
| injection/_core/common/type.py | Rewrote get_yield_hint to return tuples and updated its return type annotation |
| injection/init.pyi | Inserted an extra blank line before the inject overload |
Comments suppressed due to low confidence (1)
injection/_core/common/type.py:60
- The logic now returns an empty tuple (
()) for non-generator return types instead ofNone, changing the API contract. Ensure all callers handle a tuple return and update any downstream code or documentation that expectedNone.
if get_origin(return_type) in {
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.