Conversation
There was a problem hiding this comment.
Pull Request Overview
This pull request enhances the set_constant method to improve its API design and error handling. The main purpose is to make set_constant return the instance being registered and add validation when using type aliases.
- Modified
set_constantto return the registered instance instead ofselffor better method chaining - Added validation to raise
ValueErrorwhenalias=Truebut noonparameter is provided - Updated documentation to demonstrate the improved API usage
Reviewed Changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
injection/_core/module.py |
Core implementation changes to return instance and add alias validation |
injection/__init__.pyi |
Updated type stub to reflect new return type |
tests/core/test_module.py |
Added test coverage for the new ValueError and renamed existing test |
documentation/basic-usage.md |
Updated example to show improved usage pattern |
documentation/entrypoint.md |
Fixed function call by removing extra parameter |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.