Conversation
There was a problem hiding this comment.
Pull Request Overview
This PR introduces a new environment variable PYTHON_INJECTION_THREADSAFE that allows users to enable thread safety globally for the dependency injection library. The change modifies the default behavior from non-threadsafe to configurable thread safety.
Key changes:
- Added environment variable support to control global thread safety settings
- Updated the
get_lockfunction to check the environment variable whenthreadsafeparameter is None - Updated documentation to explain the new threadsafe configuration option
Reviewed Changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| injection/_core/common/threading.py | Adds environment variable parsing and updates lock logic to use global threadsafe setting |
| README.md | Updates documentation to explain the new environment variable and threadsafe behavior |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.