fix(web): clear stale verification terminal state

Author: wynxing

web/src/stores/useRuntimeInsightStore.test.ts

@@ -38,6 +38,29 @@ describe('useRuntimeInsightStore', () => {
 
     store.failVerification({ stop_reason: 'error', error_class: 'TestError' })
     expect(useRuntimeInsightStore.getState().verificationFailed?.error_class).toBe('TestError')
+    expect(useRuntimeInsightStore.getState().verificationCompleted).toBeNull()
+  })
+
+  it('clears a stale failed terminal state when verification later completes', () => {
+    const store = useRuntimeInsightStore.getState()
+
+    store.failVerification({ stop_reason: 'error', error_class: 'TestError' })
+    store.completeVerification({ stop_reason: 'accepted' })
+
+    const state = useRuntimeInsightStore.getState()
+    expect(state.verificationCompleted?.stop_reason).toBe('accepted')
+    expect(state.verificationFailed).toBeNull()
+  })
+
+  it('clears a stale completed terminal state when verification later fails', () => {
+    const store = useRuntimeInsightStore.getState()
+
+    store.completeVerification({ stop_reason: 'accepted' })
+    store.failVerification({ stop_reason: 'error', error_class: 'TestError' })
+
+    const state = useRuntimeInsightStore.getState()
+    expect(state.verificationFailed?.error_class).toBe('TestError')
+    expect(state.verificationCompleted).toBeNull()
   })
 
   it('resets all insight state', () => {

web/src/stores/useRuntimeInsightStore.ts

@@ -81,8 +81,14 @@ export const useRuntimeInsightStore = create<RuntimeInsightState>((set) => ({
   setCheckpointDiff: (checkpointDiff) => set({ checkpointDiff }),
   addCheckpointEvent: (event) => set((s) => ({ checkpointEvents: [...s.checkpointEvents, event] })),
   setCheckpointWarning: (checkpointWarning) => set({ checkpointWarning }),
-  completeVerification: (verificationCompleted) => set({ verificationCompleted }),
-  failVerification: (verificationFailed) => set({ verificationFailed }),
+  completeVerification: (verificationCompleted) => set({
+    verificationCompleted,
+    verificationFailed: null,
+  }),
+  failVerification: (verificationFailed) => set({
+    verificationFailed,
+    verificationCompleted: null,
+  }),
   setAcceptanceDecision: (acceptanceDecision) => set({ acceptanceDecision }),
   setTodoSnapshot: (todoSnapshot) => set((s) => {
     const items = todoSnapshot?.items ?? []