@@ -343,12 +343,25 @@ func TestNormalizeJSONRPCRequestApprovePlan(t *testing.T) {
343343 })
344344
345345 tests := []struct {
346- name string
347- params string
346+ name string
347+ params string
348+ wantGatewayCode string
348349 }{
349- {name : "missing session" , params : `{"session_id":" ","plan_id":"plan-1","revision":1}` },
350- {name : "missing plan" , params : `{"session_id":"session-1","plan_id":" ","revision":1}` },
351- {name : "invalid revision" , params : `{"session_id":"session-1","plan_id":"plan-1","revision":0}` },
350+ {
351+ name : "missing session" ,
352+ params : `{"session_id":" ","plan_id":"plan-1","revision":1}` ,
353+ wantGatewayCode : GatewayCodeMissingRequiredField ,
354+ },
355+ {
356+ name : "missing plan" ,
357+ params : `{"session_id":"session-1","plan_id":" ","revision":1}` ,
358+ wantGatewayCode : GatewayCodeMissingRequiredField ,
359+ },
360+ {
361+ name : "invalid revision" ,
362+ params : `{"session_id":"session-1","plan_id":"plan-1","revision":0}` ,
363+ wantGatewayCode : GatewayCodeInvalidAction ,
364+ },
352365 }
353366 for _ , tt := range tests {
354367 t .Run (tt .name , func (t * testing.T ) {
@@ -361,6 +374,9 @@ func TestNormalizeJSONRPCRequestApprovePlan(t *testing.T) {
361374 if rpcErr == nil || rpcErr .Code != JSONRPCCodeInvalidParams {
362375 t .Fatalf ("expected invalid params error, got %#v" , rpcErr )
363376 }
377+ if gatewayCode := GatewayCodeFromJSONRPCError (rpcErr ); gatewayCode != tt .wantGatewayCode {
378+ t .Fatalf ("gateway_code = %q, want %q" , gatewayCode , tt .wantGatewayCode )
379+ }
364380 })
365381 }
366382}
0 commit comments