test(feishu): raise adapter coverage

test(feishu): raise adapter coverage

Author: Cai-Tang-www

internal/cli/feishu_adapter_command_test.go

@@ -184,6 +184,24 @@ func TestInjectFeishuSecretsFromEnvLoadsSDKSecret(t *testing.T) {
 	}
 }
 
+func TestInjectFeishuSecretsFromEnvHandlesNilAndWebhookSkipVerify(t *testing.T) {
+	if err := injectFeishuSecretsFromEnv(nil); err == nil || err.Error() != "feishu options are required" {
+		t.Fatalf("unexpected nil options error: %v", err)
+	}
+
+	t.Setenv(config.FeishuAppSecretEnvVar, "app-secret")
+	options := mergedFeishuOptions{
+		Ingress:                config.FeishuIngressWebhook,
+		InsecureSkipSignVerify: true,
+	}
+	if err := injectFeishuSecretsFromEnv(&options); err != nil {
+		t.Fatalf("inject webhook secret with skip verify: %v", err)
+	}
+	if options.SigningSecret != "" {
+		t.Fatalf("expected signing secret to stay empty when skip verify is enabled, got %q", options.SigningSecret)
+	}
+}
+
 type stubFeishuGatewayClient struct {
 	closed bool
 }
@@ -375,3 +393,14 @@ func TestDefaultFeishuAdapterCommandRunnerPropagatesLoadAndValidateError(t *test
 		t.Fatal("expected validation error from config")
 	}
 }
+
+func TestDefaultFeishuAdapterCommandRunnerPropagatesMissingSecretEnv(t *testing.T) {
+	writeFeishuAdapterConfig(t)
+	t.Setenv(config.FeishuAppSecretEnvVar, "")
+	t.Setenv(config.FeishuSigningSecretEnvVar, "")
+
+	err := defaultFeishuAdapterCommandRunner(context.Background(), feishuAdapterCommandOptions{})
+	if err == nil || err.Error() != "config: feishu: "+config.FeishuAppSecretEnvVar+" is required when feishu.enabled=true" {
+		t.Fatalf("runner error = %v, want config validation error", err)
+	}
+}

internal/config/feishu_test.go

@@ -97,6 +97,23 @@ func TestFeishuConfigValidateRequiresAppSecretEnv(t *testing.T) {
 	}
 }
 
+func TestFeishuConfigValidateRejectsInvalidIngress(t *testing.T) {
+	t.Setenv(FeishuAppSecretEnvVar, "secret")
+	cfg := FeishuConfig{
+		Enabled:              true,
+		Ingress:              "invalid",
+		AppID:                "app",
+		RequestTimeoutSec:    8,
+		IdempotencyTTLSec:    600,
+		ReconnectBackoffMinM: 500,
+		ReconnectBackoffMaxM: 10000,
+		RebindIntervalSec:    15,
+	}
+	if err := cfg.Validate(); err == nil {
+		t.Fatal("expected invalid ingress error")
+	}
+}
+
 func TestFeishuConfigApplyDefaults(t *testing.T) {
 	var cfg FeishuConfig
 	cfg.ApplyDefaults(FeishuConfig{