Consider not requiring SVN credentials for dry-run#164
Merged
Conversation
iftakharul-islam
requested review from
Sidsector9
and removed request for
a team
jeffpaul
requested review from
iamdharmesh
and removed request for
Sidsector9
iamdharmesh
requested changes
Feb 8, 2025
Member
iamdharmesh
left a comment
iamdharmesh
left a comment
There was a problem hiding this comment.
Hi @iftakharul-islam 👋, Thanks for the PR, it looks great! I just wanted to share a minor suggestion: how about adding a warning in dry-run in case SVN credentials are missing to make developers aware of it, as suggested in the issue description? Thanks a lot for your help with this!
Contributor
Author
|
@iamdharmesh Thanks for your feedback and I've added SVN secrets warning. |
iamdharmesh
approved these changes
Feb 10, 2025
Member
iamdharmesh
left a comment
iamdharmesh
left a comment
There was a problem hiding this comment.
Thanks for the changes @iftakharul-islam. LGTM.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SVN credentials are only required when the script is performing a real deployment (not during dry-run).
Closes #149
How to test the Change
dry-run: true.SVN_USERNAMEandSVN_PASSWORD).Credits
Props @aaemnnosttv ...
Checklist: