Skip to content

Consider not requiring SVN credentials for dry-run #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
iamdharmesh merged 3 commits into from
Feb 10, 2025
+22 −11
Merged

Consider not requiring SVN credentials for dry-run #164

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
bb2cbf1
Consider not requiring SVN credentials for dry-run
iftakharul-islam Feb 7, 2025
89884f1
Updated README
iftakharul-islam Feb 7, 2025
e137dbc
Warning for SVN secrets
iftakharul-islam Feb 8, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ This Action commits the contents of your Git tag to the WordPress.org plugin rep
### Inputs

* `generate-zip` - Defaults to `false`. Generate a ZIP file from the SVN `trunk` directory. Outputs a `zip-path` variable for use in further workflow steps.
* `dry-run` - Defaults to `false`. Set this to `true` if you want to skip the final Subversion commit step (e.g., to debug prior to a non-dry-run commit).
* `dry-run` - Defaults to `false`. Set this to `true` if you want to skip the final Subversion commit step (e.g., to debug prior to a non-dry-run commit). `dry-run` - `true` Doesn't require SVN secret.

### Outputs

Expand Down
31 changes: 21 additions & 10 deletions deploy.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,18 +36,29 @@ fi
# IMPORTANT: while secrets are encrypted and not viewable in the GitHub UI,
# they are by necessity provided as plaintext in the context of the Action,
# so do not echo or use debug mode unless you want your secrets exposed!
if [[ -z "$SVN_USERNAME" ]]; then
echo "Set the SVN_USERNAME secret"
exit 1
fi

if [[ -z "$SVN_PASSWORD" ]]; then
echo "Set the SVN_PASSWORD secret"
exit 1
fi

# Check if it's a dry-run first
if $INPUT_DRY_RUN; then
echo "ℹ︎ Dry run: No files will be committed to Subversion."
echo "ℹ︎ Dry run: No files will be committed to Subversion."

if [[ -z "$SVN_USERNAME" ]]; then
echo "Warning: SVN_USERNAME is missing. The commit will fail if you attempt a real run."
fi

if [[ -z "$SVN_PASSWORD" ]]; then
echo "Warning: SVN_PASSWORD is missing. The commit will fail if you attempt a real run."
fi
else
# If it's not a dry-run, check for SVN credentials
if [[ -z "$SVN_USERNAME" ]]; then
echo "Set the SVN_USERNAME secret"
exit 1
fi

if [[ -z "$SVN_PASSWORD" ]]; then
echo "Set the SVN_PASSWORD secret"
exit 1
fi
fi

# Allow some ENV variables to be customized
Expand Down