Conversation
|
Moving this to |
|
@peterwilsoncc, Can you provide a list of data we should remove when someone installs a plugin? |
|
@peterwilsoncc I've added a few commits and included a couple of questions for confirmation. Could you please take a look at #540 (comment) and #540 (comment)? |
|
@peterwilsoncc I’m now retrieving both the option IDs and names. IDs to delete the records, and names to clear the caches. For multisite, I’m using |
peterwilsoncc
left a comment
There was a problem hiding this comment.
This is looking good but some odd behaviour when I try to delete the plugin
- the dist/css file can't be deleted.
- The database queries on a single site were failing. Not sure why.
To test I've been running the release script and unzipping and activating a duplicate copy to make sure I don't delete the git repo.
There was a problem hiding this comment.
File needs to be added to this block of code
distributor/webpack.config.release.js
Lines 11 to 29 in c27d99a
|
Hey @peterwilsoncc, I tested again on both a multisite network and a single site, but I didn’t encounter any odd behavior when deleting the plugin.
I also ran the release script and used the zip to test. Can you please check again? Or @qasumitbagthariya if you have some time to test this, that would be great. |
peterwilsoncc
left a comment
There was a problem hiding this comment.
@faisal-alvi Looks like it was file permission error between my local and virtual environments. Once I ran chmod it worked as expected.
|
@qasumitbagthariya over to you for QA |
QA Update ✅I have verified this PR in the I tested the following on this branch:
Screen.Recording.2025-09-09.at.3.15.31.PM.movTesting Environment Details
Steps to Test- As mentioned in the PR description.
|
9f2ba14

Description of the Change
uninstall.phpscript to delete distributor data from the database.DT_REMOVE_ALL_DATAconstant to prevent accidental data deletion.A modal will display when deactivating the plugin. This modal does not display in sub-sites.
Benefits
Delete distributor data on uninstalling.
Possible Drawbacks
n/a
Verification Process
Check the database manually.
Checklist:
Applicable Issues
Closes #349
Changelog Entry
Credits
Props @dinhtungdu, @faisal-alvi, @peterwilsoncc, @ravinderk, @qasumitbagthariya, @jeffpaul, @dkotter