Explicitly mark parameter as nullable to address PHP deprecation warning#262
Merged
Merged
Conversation
agibson-godaddy
marked this pull request as ready for review
December 2, 2025 15:57
There was a problem hiding this comment.
Pull request overview
This PR addresses a PHP deprecation warning by explicitly marking a parameter as nullable using the ? syntax instead of relying on implicit nullability through the default value.
- Updated the
run()method signature inTestCase.phpto use explicit nullable type syntax (?TestResult) - Added changelog entry documenting the deprecation fix
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| php/WP_Mock/Tools/TestCase.php | Changed parameter type from TestResult $result = null to ?TestResult $result = null to explicitly mark as nullable |
| CHANGELOG.md | Added version 1.1.1 entry documenting the fix for PHP deprecation warnings |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This marks a parameter explicitly as being nullable, to address this deprecation warning:
Closes: #261
Details
Contributor checklist
Testing
Reviewer checklist