Cover missing colo metadata in preamble#14
Open
KairosOps wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #13.
Cloudflare metadata can omit
coloor return it asnull. The current fallback path should reportUnknowninstead of crashing, but the test suite only exercised the live endpoint and did not pin down that response shape.This adds mocked
preamble()coverage for both missing and nullcolometadata, so the fallback stays covered without relying on the live Cloudflare response.Checked locally:
python -m pytest tests\all_test.py::test_preamble_handles_missing_colo_metadata -qpython -m py_compile cf_speedtest\speedtest.py tests\all_test.pypython -m pytest -q