Skip to content

Commit 4443ed1

Browse files
authored
fix: nil pointer dereference when os.OpenFile fails (#12808)
1 parent 81f11f1 commit 4443ed1

1 file changed

Lines changed: 6 additions & 2 deletions

File tree

agent/app/service/website_ssl.go

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -199,8 +199,12 @@ func (w WebsiteSSLService) Create(create request.WebsiteSSLCreate) (request.Webs
199199
return res, err
200200
}
201201
create.ID = websiteSSL.ID
202-
logFile, _ := os.OpenFile(path.Join(global.Dir.SSLLogDir, fmt.Sprintf("%s-ssl-%d.log", websiteSSL.PrimaryDomain, websiteSSL.ID)), os.O_CREATE|os.O_WRONLY|os.O_TRUNC, constant.FilePerm)
203-
logFile.Close()
202+
logFile, err := os.OpenFile(path.Join(global.Dir.SSLLogDir, fmt.Sprintf("%s-ssl-%d.log", websiteSSL.PrimaryDomain, websiteSSL.ID)), os.O_CREATE|os.O_WRONLY|os.O_TRUNC, constant.FilePerm)
203+
if err != nil {
204+
global.LOG.Errorf("open ssl log file failed, domain: %s, err: %v", websiteSSL.PrimaryDomain, err)
205+
} else {
206+
logFile.Close()
207+
}
204208
go func() {
205209
if create.Provider != constant.DnsManual {
206210
if err = w.ObtainSSL(request.WebsiteSSLApply{

0 commit comments

Comments
 (0)