fix: enhance app icon download logic to include file existence check#11796
Conversation
- Updated the downloadAppIcon function to parse the icon field for the file name and ETag. - Added a condition to check if the icon file exists before setting the If-None-Match header for the request.
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
- Updated GetAppIcon method to include filename in the response. - Added a condition to ensure the ETag header is set only if both ETag and filename are present, enhancing the integrity of the caching mechanism.
…Panel-dev#11796) * fix: enhance app icon download logic to include file existence check - Updated the downloadAppIcon function to parse the icon field for the file name and ETag. - Added a condition to check if the icon file exists before setting the If-None-Match header for the request. * fix: improve app icon retrieval logic by adding filename check - Updated GetAppIcon method to include filename in the response. - Added a condition to ensure the ETag header is set only if both ETag and filename are present, enhancing the integrity of the caching mechanism.
2 participants
@zhengkunwang223