refactor: clean up ollama pull log parsing#12414
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: c418e68c99
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| } | ||
| if strings.Contains(trimmed, prefix) { | ||
| lines[idx] = time.Now().Format("2006/01/02 15:04:05") + " " + newLine | ||
| return os.WriteFile(taskItem.Task.LogFile, []byte(strings.Join(lines, "\n")), os.ModePerm) |
There was a problem hiding this comment.
replaceOllamaPullLogLine rewrites taskItem.Task.LogFile with os.WriteFile, but the task logger keeps an already-open descriptor to the same file (from task.NewTask), opened without O_APPEND. After a truncate-and-rewrite, subsequent taskItem.Log(...) calls continue writing at the old offset, which can introduce NUL gaps and corrupt later log lines. This is reproducible whenever a pulling ... progress line is replaced and then any later log entry is emitted (for example subtask success/end markers).
Useful? React with 👍 / 👎.
|
/approve |
3 participants
No description provided.