fix: avoid license required before login#12623
Conversation
|
Adding the "do-not-merge/release-note-label-needed" label because no release-note block was detected, please follow our release note process to remove it. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here. DetailsNeeds approval from an approver in each of these files:Approvers can indicate their approval by writing |
ssongliu
force-pushed
the
fix/login-license-required-redirect
branch
from
b325fb6 to
bf0b860
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b325fb66dd
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| if (licenseStatusLoaded) { | ||
| return GlobalStore().isXpackEELicensed; |
There was a problem hiding this comment.
loadXpackEELicenseStatus now returns early from a module-level cache, but that cache is only cleared by clearLoginStatus() and is not reset on normal logout or when currentNode changes. Since this check uses node-scoped headers when it does fetch, reusing a stale cached value can misroute users after a node/session change (for example, continuing to redirect to XpackEELicenseRequired even when the new node is licensed).
Useful? React with 👍 / 👎.
2 participants
No description provided.