Skip to content

Fix invalid postion of before content in home page#7429

Merged
zhengkunwang223 merged 1 commit into1Panel-dev:devfrom
JohnNiang:bug/home-page-ui-style
Dec 18, 2024
Merged

Fix invalid postion of before content in home page#7429
zhengkunwang223 merged 1 commit into1Panel-dev:devfrom
JohnNiang:bug/home-page-ui-style

Conversation

@JohnNiang
Copy link
Copy Markdown
Member

What this PR does / why we need it?

When I open 1Panel in Firefox on Linux(133.0.3) and Chrome(131.0.6778.139), all before contents of headers in home page are born in a wrong position. Please see the screenshot below:

image

image

This PR fixes the problem completely. See the screenshots below:

image

image

Please indicate you've done the following:

  • Made sure tests are passing and test coverage is added if needed.
  • Made sure commit message follow the rule of Conventional Commits specification.
  • Considered the docs impact and opened a new docs issue or PR with docs changes if needed.
None

@f2c-ci-robot
Copy link
Copy Markdown

f2c-ci-robot bot commented Dec 18, 2024

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please assign ssongliu for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@zhengkunwang223 zhengkunwang223 merged commit 063a071 into 1Panel-dev:dev Dec 18, 2024
@JohnNiang JohnNiang deleted the bug/home-page-ui-style branch December 18, 2024 10:44
@JohnNiang
Copy link
Copy Markdown
Member Author

/cherrypick dev-v2

@halo-dev-bot
Copy link
Copy Markdown
Contributor

@JohnNiang: only 1Panel-dev org members may request cherry picks. If you are already part of the org, make sure to change your membership to public. Otherwise you can still do the cherry-pick manually.

Details

In response to this:

/cherrypick dev-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@JohnNiang
Copy link
Copy Markdown
Member Author

/cherrypick dev-v2

@halo-dev-bot
Copy link
Copy Markdown
Contributor

@JohnNiang: new pull request created: #8980

Details

In response to this:

/cherrypick dev-v2

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants