Skip to content

fix: Modify the panel password verification rule #8291

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
f2c-ci-robot merged 1 commit into from
Apr 2, 2025
Merged

fix: Modify the panel password verification rule #8291

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions frontend/src/views/setting/expired.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -59,12 +59,8 @@ let isComplexity = ref(false);
type FormInstance = InstanceType<typeof ElForm>;
const passFormRef = ref<FormInstance>();
const passRules = reactive({
oldPass: [Rules.noSpace, Rules.requiredInput],
newPass: [
Rules.requiredInput,
Rules.noSpace,
{ min: 6, message: i18n.global.t('commons.rule.commonPassword'), trigger: 'blur' },
],
oldPass: [Rules.requiredInput, Rules.noSpace],
newPass: [Rules.requiredInput, Rules.noSpace],
newPassComplexity: [Rules.requiredInput, Rules.noSpace, Rules.password],
rePass: [Rules.requiredInput, Rules.noSpace, { validator: checkPasswordSame, trigger: 'blur' }],
});
Copy link
Copy Markdown
Member

@wanghe-fit2cloud wanghe-fit2cloud Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code does not contain any irregularities or potential issues. The only difference appears to be that rules for oldPass and newPassComplexity were removed from the second set of rules. Since these fields do not appear to have additional validation logic, no immediate optimizations are needed.

Expand Down
8 changes: 2 additions & 6 deletions frontend/src/views/setting/panel/password/index.vue
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,12 +70,8 @@ import { logOutApi } from '@/api/modules/auth';
const globalStore = GlobalStore();
const passFormRef = ref<FormInstance>();
const passRules = reactive({
oldPassword: [Rules.noSpace, Rules.requiredInput],
newPassword: [
Rules.requiredInput,
Rules.noSpace,
{ min: 6, message: i18n.global.t('commons.rule.commonPassword'), trigger: 'blur' },
],
oldPassword: [Rules.requiredInput, Rules.noSpace],
newPassword: [Rules.requiredInput, Rules.noSpace],
newPasswordComplexity: [Rules.requiredInput, Rules.noSpace, Rules.password],
retryPassword: [Rules.requiredInput, Rules.noSpace, { validator: checkPassword, trigger: 'blur' }],
});
Copy link
Copy Markdown
Member

@wanghe-fit2cloud wanghe-fit2cloud Apr 2, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There is one issue found in the code:

Lines 73 to 76 have been removed from the passRules object. This change removes the minimum length validation rule for both new password fields (newPassword) which required passwords be at least six characters long.

Optimization suggestion:
While removing this rule might save on processing time during input validation, it should be reconsidered before implementation if there are concerns with user experience related to requiring stronger passwords (e.g., complexity requirements). You may want to keep it in place or provide an option allowing users to specify password complexity options that align with your security policies.

Expand Down
Loading